mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org,
	Patrice Vilchez <patrice.vilchez@atmel.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [PATCH] at91sam9m10g45ek: add board revision support
Date: Sat, 15 Jan 2011 16:50:35 +0100	[thread overview]
Message-ID: <20110115155035.GD14798@game.jcrosoft.org> (raw)
In-Reply-To: <20110115152555.GE9041@pengutronix.de>

> > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> > index e5bd45e..4d35ebe 100644
> > --- a/arch/arm/mach-at91/Kconfig
> > +++ b/arch/arm/mach-at91/Kconfig
> > @@ -174,7 +174,8 @@ config MACH_AT91SAM9M10G45EK
> >  	bool "Atmel AT91SAM9M10G45-EK Evaluation Kit"
> >  	select HAVE_NAND_ATMEL_BUSWIDTH_16
> >  	help
> > -	  Select this if you are using Atmel's AT91SAM9M10G45-EK Evaluation Kit.
> > +	  Select this if you are using Atmel's AT91SAM9M10G45-EK Evaluation Kit
> > +	  or AT91SAM9G45-EKES or AT91SAM9M10-EKES (for those 2 select the LG LCD)
> >  	  <http://atmel.com/dyn/products/tools_card_v2.asp?tool_id=4735>
> 
> Isn't it better to let the user choose the exact board type here and
> select the display type automatically depending on the choice?
They are nearly the same board and the idea is to allow to specify the lcd as
we can change it and it's the only difference between the 3 boards,

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-01-15 15:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-15  2:25 Jean-Christophe PLAGNIOL-VILLARD
2011-01-15 15:25 ` Sascha Hauer
2011-01-15 15:50   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-01-15 16:21     ` Sascha Hauer
2011-01-22 15:45 ` [PATCH v2] " Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110115155035.GD14798@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=patrice.vilchez@atmel.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox