From: Sascha Hauer <s.hauer@pengutronix.de>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 05/10] i.MX23/28: Fix setting of lcd clock
Date: Fri, 21 Jan 2011 10:37:52 +0100 [thread overview]
Message-ID: <20110121093752.GZ9041@pengutronix.de> (raw)
In-Reply-To: <4D387667.5060607@free-electrons.com>
On Thu, Jan 20, 2011 at 06:52:39PM +0100, Gregory CLEMENT wrote:
> On 01/20/2011 03:57 PM, Sascha Hauer wrote:
> > On Thu, Jan 20, 2011 at 03:01:47PM +0100, Gregory CLEMENT wrote:
> >> On 01/20/2011 10:46 AM, Sascha Hauer wrote:
> >>> Use the correct bitmask for masking out which is
> >>> SET_PIXFRAC(MASK_PIXFRAC)
> >>>
> >>
> >> I was just about to send you the same kind of patch, as this bug bit me during
> >> kernel boot when using cpufreq.
> >>
> >> As you are working on imx23 and video driver, what do you think of my previous
> >> patches ? I sent them in January the 4th:
> >>
> >> ARM STM/i.MX: Add possibility to choose the bit per pixel for STM
> >> video driver
> >
> > This looks ok.
> >
> >> ARM STM/i.MX: Add possibility to select the data mode for stm video
> >> driver ( DCn signal is high )
> >
> > Looks ok. What is this pin good for? Is this bit used in conjunction
> > with other bits which happen to have the right value for you?
> >
>
> You made me dig in the datasheet and check my code. And finally this
> patch is pointless! The DCn signal which seems related to LCD_RS is
> only used in MPU interface whereas we use Dotclock interface.
> I just checked again and without it, my LCD still worked. It seems
> that I forgot to test this patch alone, as my configuration need
> the following patch to work, I didn't notice this patch did nothing.
> Sorry for this fake patch :(
>
> >> ARM STM/i.MX: Add the reset control of LCD
> >
> > We use the same pin as gpio and toggle it in the platform specific hook,
> > so I could rebase my chumby patch on this one.
> >
> > For the last two patches I prefer having flags in the platform data
> > rather than having a u32 for a single flag.
> >
> How could we process?
>
> Will you get the 1st patch as is ?
>
> For the other, have you a git tree available where all your patches lie?
I merged my mx23 patches and your first patch to -next. You can rebase
your remaining patches on -next and I'll convert the chumby to use the
reset pin later.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-01-21 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 9:46 i.MX23 patches Sascha Hauer
2011-01-20 9:46 ` [PATCH 01/10] USB ehci: Set to host mode on tt capable controllers Sascha Hauer
2011-01-20 9:46 ` [PATCH 02/10] i.MX23: Add USB (phy) support Sascha Hauer
2011-01-20 9:46 ` [PATCH 03/10] ARM Chumby: Add USB support Sascha Hauer
2011-01-20 9:46 ` [PATCH 04/10] ARM Chumby: Add MMU support Sascha Hauer
2011-01-20 9:46 ` [PATCH 05/10] i.MX23/28: Fix setting of lcd clock Sascha Hauer
2011-01-20 14:01 ` Gregory CLEMENT
2011-01-20 14:57 ` Sascha Hauer
2011-01-20 17:52 ` Gregory CLEMENT
2011-01-21 9:37 ` Sascha Hauer [this message]
2011-01-20 9:46 ` [PATCH 06/10] fb i.MX23/28: add platform data hook to enable backlight Sascha Hauer
2011-01-20 9:46 ` [PATCH 07/10] ARM chumby: enable backlight in platform data hook Sascha Hauer
2011-01-20 9:46 ` [PATCH 08/10] fb i.MX23/28: rename imx_fb_videomode to imx_fb_platformdata Sascha Hauer
2011-01-20 9:47 ` [PATCH 09/10] ARM: rename STM arch to mxs Sascha Hauer
2011-01-20 9:47 ` [PATCH 10/10] ARM chumby defconfig: update with new features Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121093752.GZ9041@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=gregory.clement@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox