mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: franck.jullien@gmail.com
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 00/54] New arch (NIOS2)
Date: Fri, 4 Mar 2011 09:45:33 +0100	[thread overview]
Message-ID: <20110304084533.GD29521@pengutronix.de> (raw)
In-Reply-To: <4d701d2f.9009d80a.2cd3.5e70@mx.google.com>

Hi Franck,

On Thu, Mar 03, 2011 at 11:58:14PM +0100, franck.jullien@gmail.com wrote:
> From: Franck JULLIEN <franck.jullien@gmail.com>
> 
> This is the base files of the Nios2 port. Almost everything is comming from u-boot.
> When those files are acked, I'll post drivers and utility commands.

Soo many patches ;). You can safely combine all these into two
patches, one for the nios2 support and one for the generic board.
The patches are only useful as a whole anyway, so no need to split
them up that fine. You will hit the list limit, so give me some time
to go to the moderator interface and and it through.

I'm not through all patches, but some remarks here:

There is some whitespace damage all around like spaces which should be
tabs. Also, please do not use direct pointer derefs to access registers.
You should use readl/writel accessors for them.

Thanks for doing this work. Although I don't have a nios baord, I really
appreciate extending barebox to more architectures.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-03-04  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 22:58 franck.jullien
2011-03-04  8:45 ` Sascha Hauer [this message]
     [not found]   ` <AANLkTi=a2V+v6rOJXLmw6_6yysQBVobnqfR03VVn4P=g@mail.gmail.com>
2011-03-04  9:04     ` Fwd: " Franck JULLIEN
2011-03-04 10:33       ` Baruch Siach
2011-03-16 12:32 ` Shinya Kuribayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110304084533.GD29521@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=franck.jullien@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox