From: Sascha Hauer <s.hauer@pengutronix.de>
To: Franck JULLIEN <franck.jullien@gmail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] Add Altera Nios2 arch support
Date: Fri, 18 Mar 2011 08:49:01 +0100 [thread overview]
Message-ID: <20110318074901.GA29521@pengutronix.de> (raw)
In-Reply-To: <AANLkTikaZD-w__D-nnjMT7nbTRgodryGLqXzBFb58B49@mail.gmail.com>
On Thu, Mar 17, 2011 at 05:50:09PM +0100, Franck JULLIEN wrote:
> Hi Sascha,
>
> 2011/3/16 Sascha Hauer <s.hauer@pengutronix.de>
>
> > Hi Julien,
> >
> >
> Well....it's Franck ;) I know that's a bit confusing......
Oops, sorry
> > > +#ifndef _BAREBOX_H_
> > > +#define _BAREBOX_H_ 1
> > > +
> > > +typedef struct bd_info {
> > > + int bi_baudrate; /* serial console baudrate */
> > > + unsigned long bi_ip_addr; /* IP Address */
> > > + unsigned char bi_enetaddr[6]; /* Ethernet adress */
> > > + unsigned long bi_arch_number; /* unique id for this board */
> > > + unsigned long bi_boot_params; /* where this board expects params
> > */
> > > + unsigned long bi_memstart; /* start of DRAM memory */
> > > + unsigned long bi_memsize; /* size of DRAM memory in bytes */
> > > + unsigned long bi_flashstart; /* start of FLASH memory */
> > > + unsigned long bi_flashsize; /* size of FLASH memory */
> > > + unsigned long bi_flashoffset; /* reserved area for startup
> > monitor */
> > > +} bd_t;
> >
> > This isn't used anywhere in this patch. Is it needed for passing data to
> > Linux? If yes, ok, otherwise please remove it.
> >
>
> This file is included bu include/common.h
> Should I provide an empty file ?
Yes, please.
(As this seems only be used on ppc we should probably remove the
inclusion from common.h and include asm/barebox.h where necessary)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-03-18 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 22:46 Franck JULLIEN
2011-03-16 9:34 ` Sascha Hauer
2011-03-17 16:50 ` Franck JULLIEN
2011-03-18 7:49 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318074901.GA29521@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=franck.jullien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox