From: Sascha Hauer <s.hauer@pengutronix.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] mci: turn several pr_* statements into debug
Date: Tue, 12 Apr 2011 11:16:09 +0200 [thread overview]
Message-ID: <20110412091609.GM7285@pengutronix.de> (raw)
In-Reply-To: <201104121057.11443.jbe@pengutronix.de>
On Tue, Apr 12, 2011 at 10:57:11AM +0200, Juergen Beisert wrote:
> Mostly ACK, but ...
>
> Sascha Hauer wrote:
> > These are mostly useful for developers, so turn them off by default.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > drivers/mci/mci-core.c | 26 +++++++++++++-------------
> > 1 files changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> > index a51c44b..c4c5c2f 100644
> > --- a/drivers/mci/mci-core.c
> > +++ b/drivers/mci/mci-core.c
> >
> > [...]
> >
> > @@ -1182,7 +1182,7 @@ static int mci_card_probe(struct device_d *mci_dev)
> > /* start with a host interface reset */
> > rc = (host->init)(host, mci_dev);
> > if (rc) {
> > - pr_err("Cannot reset the SD/MMC interface\n");
> > + pr_debug("Cannot reset the SD/MMC interface\n");
> > return rc;
> > }
Really this shouldn't fail for users. Most of the driver can't fail
or print something themselves.
>
> This is not only useful for the developer. Also for the regular user when
> something is broken at runtime.
>
> > @@ -1192,7 +1192,7 @@ static int mci_card_probe(struct device_d *mci_dev)
> > /* reset the card */
> > rc = mci_go_idle(mci_dev);
> > if (rc) {
> > - pr_warning("Cannot reset the SD/MMC card\n");
> > + pr_debug("Cannot reset the SD/MMC card\n");
> > goto on_error;
> > }
>
> Also useful for the regular user, that tries his shiny new and fresh SD card
> and something went wrong at runtime.
Ok for this one as it depends on the card inserted.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-04-12 9:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 8:17 mci patches Sascha Hauer
2011-04-12 8:17 ` [PATCH 1/3] mci: shrink string footprint Sascha Hauer
2011-04-12 8:17 ` [PATCH 2/3] mci: turn several pr_* statements into debug Sascha Hauer
2011-04-12 8:57 ` Juergen Beisert
2011-04-12 9:16 ` Sascha Hauer [this message]
2011-04-12 8:17 ` [PATCH 3/3] ata: guessing disk sizes is only needed on X86 Sascha Hauer
2011-04-12 9:05 ` Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412091609.GM7285@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox