mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: MJ <mjainp@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: Sandbox Segfaults
Date: Mon, 25 Apr 2011 12:23:55 +0200	[thread overview]
Message-ID: <20110425102355.GD14770@pengutronix.de> (raw)
In-Reply-To: <BANLkTik_geZ4hpcXTdN81DEgcOeqRZT8UA@mail.gmail.com>

Hi,

On Fri, Apr 22, 2011 at 09:13:39PM +0530, MJ wrote:
> Hi,
> 
> I was trying sandbox for x86 host machine from latest git repo of
> barebox (master branch) and it segfaults when ran with following
> command line arguments,
> 
> ./barebox -e env.bin -i cramfs.bin

Please try again with the latest master branch. I fixed this issue with
the following:


commit fcad2ff58b617340230dae8cfc1e23ebc6baf108
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Mon Apr 25 11:18:49 2011 +0200

    sandbox: Fix another uninitialized dev->id case
    
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

diff --git a/arch/sandbox/board/hostfile.c b/arch/sandbox/board/hostfile.c
index 38a52a8..e460d0a 100644
--- a/arch/sandbox/board/hostfile.c
+++ b/arch/sandbox/board/hostfile.c
@@ -109,6 +109,7 @@ int barebox_register_filedev(struct hf_platform_data *hf)
 
 	strcpy(dev->name, "hostfile");
 	dev->size = hf->size;
+	dev->id = -1;
 	dev->map_base = hf->map_base;
 
 	return register_device(dev);

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-04-25 10:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 15:43 MJ
2011-04-25 10:23 ` Sascha Hauer [this message]
2011-04-25 12:11   ` MJ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110425102355.GD14770@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=mjainp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox