mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Tim Sander <tim.sander@hbm.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fix genenv when using svn based enviroment directory
Date: Mon, 23 May 2011 09:21:59 +0200	[thread overview]
Message-ID: <20110523072159.GE20715@pengutronix.de> (raw)
In-Reply-To: <201105201500.50593.tim.sander@hbm.com>

Hi Tim,

On Fri, May 20, 2011 at 03:00:50PM +0200, Tim Sander wrote:
> Hi
> 
> When setting the default env of barebox to a svn directory the build stops
> with questions on removal and the barebox env is polluted with svn files.
> 
> The patch below fixes that.
> 
> Tested with 2011.03.1. Newer versions don't boot anymore on my pcm043 :-(.
> 
> Signed-off-by: Tim Sander <tim.sander@hbm.com>
> 
> ---
>  scripts/genenv |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/genenv b/scripts/genenv
> index de8b4f1..c6bcd4b 100755
> --- a/scripts/genenv
> +++ b/scripts/genenv
> @@ -13,7 +13,9 @@ tempdir=$(mktemp -d)
>  for i in $*; do
>         cp -r $i/* $tempdir
>  done
> +find $tempdir -name .svn |xargs rm -r
> +
>  $objtree/scripts/bareboxenv -s $tempdir $objtree/barebox_default_env
>  
> -rm -r $tempdir
> +rm -rf $tempdir

Is this second change intended? If yes, why?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-05-23  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 13:00 Tim Sander
2011-05-23  7:21 ` Sascha Hauer [this message]
2011-05-23  7:47   ` [PATCH] " Tim Sander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110523072159.GE20715@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=tim.sander@hbm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox