From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2 v2] complete: add device name complete support
Date: Mon, 6 Jun 2011 11:58:13 +0200 [thread overview]
Message-ID: <20110606095813.GE23771@pengutronix.de> (raw)
In-Reply-To: <1307351484-5159-1-git-send-email-plagnioj@jcrosoft.com>
On Mon, Jun 06, 2011 at 11:11:23AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> common/complete.c | 24 ++++++++++++++++++++++++
> 1 files changed, 24 insertions(+), 0 deletions(-)
Sorry, this does not work. Pressing eth<TAB> on an empty command
line expands to
ethact (correct, this is a command)
eth0 (almost correct, it misses the '=')
'ls <TAB>' expands to
ls env/ (correct, this is a directory)
ls eth0 (incorrect, no valid expansion)
'ls n<TAB> expands to
ls nand0 (incorrect, this is a device name and can't be used here=
ls nfsroot= (incorrect, no valid expansion)
Please check the context in which you are calling the different complete
functions like I suggested in my comment to the last patch.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-06-06 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 9:11 Jean-Christophe PLAGNIOL-VILLARD
2011-06-06 9:11 ` [PATCH 2/2] complete: add var and device param " Jean-Christophe PLAGNIOL-VILLARD
2011-06-06 9:58 ` Sascha Hauer [this message]
2011-06-06 10:33 ` [PATCH 1/2 v2] complete: add device name " Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606095813.GE23771@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox