mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fix: commands/bootm.c:346:2: warning: statement with no effect
Date: Mon, 18 Jul 2011 08:26:19 +0200	[thread overview]
Message-ID: <20110718062619.GB20587@pengutronix.de> (raw)
In-Reply-To: <1310812921-3685-1-git-send-email-plagnioj@jcrosoft.com>

On Sat, Jul 16, 2011 at 12:42:01PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> convert enable_interrupts() and disable_interrupts() to static inline
> if no IRQ supoprt enable

Applied to master

Sascha

> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  include/common.h |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/include/common.h b/include/common.h
> index 491bc98..f3353c8 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -116,8 +116,14 @@ void	irq_free_handler   (int);
>  void	enable_interrupts  (void);
>  int	disable_interrupts (void);
>  #else
> -#define enable_interrupts() do {} while (0)
> -#define disable_interrupts() 0
> +static inline void enable_interrupts(void)
> +{
> +}
> +
> +static inline int disable_interrupts(void)
> +{
> +	return 0;
> +}
>  #endif
>  
>  /* lib_$(ARCH)/time.c */
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2011-07-18  6:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-16 10:42 Jean-Christophe PLAGNIOL-VILLARD
2011-07-18  6:26 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110718062619.GB20587@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox