Re: [PATCH 04/16] add a add_mem_device function - Jean-Christophe PLAGNIOL-VILLARD

From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 04/16] add a add_mem_device function
Date: Tue, 19 Jul 2011 19:10:12 +0200	[thread overview]
Message-ID: <20110719171012.GM5727@game.jcrosoft.org> (raw)
In-Reply-To: <20110719171910.GP20587@pengutronix.de>

On 19:19 Tue 19 Jul     , Sascha Hauer wrote:
> On Tue, Jul 19, 2011 at 06:09:00PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > 
> > Add a helper function for boards to register their memory
> > devices. This makes the board code smaller and also helps
> > getting rid of map_base and struct memory_platform_data.
> > 
> > And switch all of the memory to it
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> 
> > diff --git a/common/Makefile b/common/Makefile
> > index 9fed2ae..27aebae 100644
> > --- a/common/Makefile
> > +++ b/common/Makefile
> > @@ -9,6 +9,7 @@ obj-$(CONFIG_POLLER)		+= poller.o
> >  obj-$(CONFIG_BLOCK)		+= block.o
> >  
> >  obj-y += memory.o
> > +obj-y += mem.o
> 
> Seems you forgot to git add common/mem.c.
> 
> I think the previous patch can be squashed into this one. Other than
> that the series looks good.
I see I resend the v3 with it

no we need to new helpper in common otherwise the xload config will not
compile

the git is update you can pull it with the v3 of it inside

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox