mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM pcm043: New RAM timings
@ 2011-07-28 13:14 Teresa Gámez
  2011-07-28 13:14 ` [PATCH 2/2] ARM pcm043: Use PDR0 to change cpu freq Teresa Gámez
  2011-07-28 13:43 ` [PATCH 1/2] ARM pcm043: New RAM timings Sascha Hauer
  0 siblings, 2 replies; 5+ messages in thread
From: Teresa Gámez @ 2011-07-28 13:14 UTC (permalink / raw)
  To: barebox

Update RAM timings with extended row cycle delay.

Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
---
 arch/arm/boards/pcm043/lowlevel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boards/pcm043/lowlevel.c b/arch/arm/boards/pcm043/lowlevel.c
index eff96f9..bbe586b 100644
--- a/arch/arm/boards/pcm043/lowlevel.c
+++ b/arch/arm/boards/pcm043/lowlevel.c
@@ -146,7 +146,7 @@ void __bare_init __naked board_init_lowlevel(void)
 	writel(0x00000304, ESDMISC); /* was 0x00000004 */
 
 	/* set timing paramters */
-	writel(0x00255417, ESDCFG0);
+	writel(0x0025541F, ESDCFG0);
 	/* select Precharge-All mode */
 	writel(0x92220000, ESDCTL0);
 	/* Precharge-All */
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM pcm043: Use PDR0 to change cpu freq
  2011-07-28 13:14 [PATCH 1/2] ARM pcm043: New RAM timings Teresa Gámez
@ 2011-07-28 13:14 ` Teresa Gámez
  2011-07-28 14:11   ` Marc Kleine-Budde
  2011-07-28 13:43 ` [PATCH 1/2] ARM pcm043: New RAM timings Sascha Hauer
  1 sibling, 1 reply; 5+ messages in thread
From: Teresa Gámez @ 2011-07-28 13:14 UTC (permalink / raw)
  To: barebox

Instead of changing the MPCTL to set an other cpu frequency,
use the post divider.

This prevents freezing when changing the clock from 399MHz to 532MHz.

Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
---
 arch/arm/boards/pcm043/pcm043.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
index 3bd6402..8629ae6 100644
--- a/arch/arm/boards/pcm043/pcm043.c
+++ b/arch/arm/boards/pcm043/pcm043.c
@@ -308,8 +308,8 @@ static int pcm043_core_setup(void)
 
 core_initcall(pcm043_core_setup);
 
-#define MPCTL_PARAM_399     (IMX_PLL_PD(0) | IMX_PLL_MFD(15) | IMX_PLL_MFI(8) | IMX_PLL_MFN(5))
-#define MPCTL_PARAM_532     ((1 << 31) | IMX_PLL_PD(0) | IMX_PLL_MFD(11) | IMX_PLL_MFI(11) | IMX_PLL_MFN(1))
+#define	CCM_PDR0_PARAM_399	((1 << 12) | (1 << 16))
+#define	CCM_PDR0_PARAM_532	(1 << 12)
 
 static int do_cpufreq(struct command *cmdtp, int argc, char *argv[])
 {
@@ -322,10 +322,10 @@ static int do_cpufreq(struct command *cmdtp, int argc, char *argv[])
 
 	switch (freq) {
 	case 399:
-		writel(MPCTL_PARAM_399, IMX_CCM_BASE + CCM_MPCTL);
+		writel(CCM_PDR0_PARAM_399, IMX_CCM_BASE + CCM_PDR0);
 		break;
 	case 532:
-		writel(MPCTL_PARAM_532, IMX_CCM_BASE + CCM_MPCTL);
+		writel(CCM_PDR0_PARAM_532, IMX_CCM_BASE + CCM_PDR0);
 		break;
 	default:
 		return COMMAND_ERROR_USAGE;
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM pcm043: New RAM timings
  2011-07-28 13:14 [PATCH 1/2] ARM pcm043: New RAM timings Teresa Gámez
  2011-07-28 13:14 ` [PATCH 2/2] ARM pcm043: Use PDR0 to change cpu freq Teresa Gámez
@ 2011-07-28 13:43 ` Sascha Hauer
  2011-08-22 13:49   ` Teresa Gamez
  1 sibling, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2011-07-28 13:43 UTC (permalink / raw)
  To: Teresa Gámez; +Cc: barebox

Hi Teresa,

On Thu, Jul 28, 2011 at 03:14:13PM +0200, Teresa Gámez wrote:
> Update RAM timings with extended row cycle delay.
> 
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> ---
>  arch/arm/boards/pcm043/lowlevel.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/boards/pcm043/lowlevel.c b/arch/arm/boards/pcm043/lowlevel.c
> index eff96f9..bbe586b 100644
> --- a/arch/arm/boards/pcm043/lowlevel.c
> +++ b/arch/arm/boards/pcm043/lowlevel.c
> @@ -146,7 +146,7 @@ void __bare_init __naked board_init_lowlevel(void)
>  	writel(0x00000304, ESDMISC); /* was 0x00000004 */
>  
>  	/* set timing paramters */
> -	writel(0x00255417, ESDCFG0);
> +	writel(0x0025541F, ESDCFG0);

Does this work on all boards or is this an update for newer sdrams?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] ARM pcm043: Use PDR0 to change cpu freq
  2011-07-28 13:14 ` [PATCH 2/2] ARM pcm043: Use PDR0 to change cpu freq Teresa Gámez
@ 2011-07-28 14:11   ` Marc Kleine-Budde
  0 siblings, 0 replies; 5+ messages in thread
From: Marc Kleine-Budde @ 2011-07-28 14:11 UTC (permalink / raw)
  To: Teresa Gámez; +Cc: barebox


[-- Attachment #1.1: Type: text/plain, Size: 1865 bytes --]

On 07/28/2011 03:14 PM, Teresa Gámez wrote:
> Instead of changing the MPCTL to set an other cpu frequency,
> use the post divider.
> 
> This prevents freezing when changing the clock from 399MHz to 532MHz.
> 
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> ---
>  arch/arm/boards/pcm043/pcm043.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
> index 3bd6402..8629ae6 100644
> --- a/arch/arm/boards/pcm043/pcm043.c
> +++ b/arch/arm/boards/pcm043/pcm043.c
> @@ -308,8 +308,8 @@ static int pcm043_core_setup(void)
>  
>  core_initcall(pcm043_core_setup);
>  
> -#define MPCTL_PARAM_399     (IMX_PLL_PD(0) | IMX_PLL_MFD(15) | IMX_PLL_MFI(8) | IMX_PLL_MFN(5))
> -#define MPCTL_PARAM_532     ((1 << 31) | IMX_PLL_PD(0) | IMX_PLL_MFD(11) | IMX_PLL_MFI(11) | IMX_PLL_MFN(1))
> +#define	CCM_PDR0_PARAM_399	((1 << 12) | (1 << 16))
> +#define	CCM_PDR0_PARAM_532	(1 << 12)

nickpick: no tab after #define, please

Marc
>  
>  static int do_cpufreq(struct command *cmdtp, int argc, char *argv[])
>  {
> @@ -322,10 +322,10 @@ static int do_cpufreq(struct command *cmdtp, int argc, char *argv[])
>  
>  	switch (freq) {
>  	case 399:
> -		writel(MPCTL_PARAM_399, IMX_CCM_BASE + CCM_MPCTL);
> +		writel(CCM_PDR0_PARAM_399, IMX_CCM_BASE + CCM_PDR0);
>  		break;
>  	case 532:
> -		writel(MPCTL_PARAM_532, IMX_CCM_BASE + CCM_MPCTL);
> +		writel(CCM_PDR0_PARAM_532, IMX_CCM_BASE + CCM_PDR0);
>  		break;
>  	default:
>  		return COMMAND_ERROR_USAGE;


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ARM pcm043: New RAM timings
  2011-07-28 13:43 ` [PATCH 1/2] ARM pcm043: New RAM timings Sascha Hauer
@ 2011-08-22 13:49   ` Teresa Gamez
  0 siblings, 0 replies; 5+ messages in thread
From: Teresa Gamez @ 2011-08-22 13:49 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

Hello Sascha,

Am Donnerstag, den 28.07.2011, 15:43 +0200 schrieb Sascha Hauer:
> Hi Teresa,
> 
> On Thu, Jul 28, 2011 at 03:14:13PM +0200, Teresa Gámez wrote:
> > Update RAM timings with extended row cycle delay.
> > 
> > Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> > ---
> >  arch/arm/boards/pcm043/lowlevel.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/boards/pcm043/lowlevel.c b/arch/arm/boards/pcm043/lowlevel.c
> > index eff96f9..bbe586b 100644
> > --- a/arch/arm/boards/pcm043/lowlevel.c
> > +++ b/arch/arm/boards/pcm043/lowlevel.c
> > @@ -146,7 +146,7 @@ void __bare_init __naked board_init_lowlevel(void)
> >  	writel(0x00000304, ESDMISC); /* was 0x00000004 */
> >  
> >  	/* set timing paramters */
> > -	writel(0x00255417, ESDCFG0);
> > +	writel(0x0025541F, ESDCFG0);
> 
> Does this work on all boards or is this an update for newer sdrams?

Sorry for my late answer. The timings are an update for newer sdrams.
But the timings where successfully tested with older sdrams.

I'll resend the patch with a new description. 

Teresa

> 
> Sascha
> 



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-22 13:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-28 13:14 [PATCH 1/2] ARM pcm043: New RAM timings Teresa Gámez
2011-07-28 13:14 ` [PATCH 2/2] ARM pcm043: Use PDR0 to change cpu freq Teresa Gámez
2011-07-28 14:11   ` Marc Kleine-Budde
2011-07-28 13:43 ` [PATCH 1/2] ARM pcm043: New RAM timings Sascha Hauer
2011-08-22 13:49   ` Teresa Gamez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox