[PATCH] commands/led.c: fix return codes

[PATCH] commands/led.c: fix return codes

[Antony Pavlov]

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 commands/led.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/commands/led.c b/commands/led.c
index 360ce7c..afb3fd3 100644
--- a/commands/led.c
+++ b/commands/led.c
@@ -45,7 +45,7 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
 					led->max_value);
 			i++;
 		}
-		return 0;
+		return COMMAND_SUCCESS;
 	}
 
 	if (argc != 3)
@@ -54,7 +54,7 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
 	led = led_by_name_or_number(argv[1]);
 	if (!led) {
 		printf("no such LED: %s\n", argv[1]);
-		return 1;
+		return COMMAND_ERROR;
 	}
 
 	value = simple_strtoul(argv[optind + 1], NULL, 0);
@@ -62,10 +62,10 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
 	ret = led_set(led, value);
 	if (ret < 0) {
 		perror("led");
-		return 1;
+		return COMMAND_ERROR;
 	}
 
-	return 0;
+	return COMMAND_SUCCESS;
 }
 
 /**
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] commands/led.c: fix return codes

[Sascha Hauer]

On Tue, Aug 02, 2011 at 11:08:08AM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  commands/led.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/commands/led.c b/commands/led.c

As of now noone uses the COMMAND_ERROR/COMMAND_SUCCESS macros.
I'm not sure they are the way to go anyway. What I would rather
like to see is that commands can return the standard error
values, but this requires changes in hush.c (and the simple
parser), because hush currently has its own (strange) way
of interpreting return codes.

Sascha

> index 360ce7c..afb3fd3 100644
> --- a/commands/led.c
> +++ b/commands/led.c
> @@ -45,7 +45,7 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
>  					led->max_value);
>  			i++;
>  		}
> -		return 0;
> +		return COMMAND_SUCCESS;
>  	}
>  
>  	if (argc != 3)
> @@ -54,7 +54,7 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
>  	led = led_by_name_or_number(argv[1]);
>  	if (!led) {
>  		printf("no such LED: %s\n", argv[1]);
> -		return 1;
> +		return COMMAND_ERROR;
>  	}
>  
>  	value = simple_strtoul(argv[optind + 1], NULL, 0);
> @@ -62,10 +62,10 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
>  	ret = led_set(led, value);
>  	if (ret < 0) {
>  		perror("led");
> -		return 1;
> +		return COMMAND_ERROR;
>  	}
>  
> -	return 0;
> +	return COMMAND_SUCCESS;
>  }
>  
>  /**
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH] commands/led.c: fix return code

[Antony Pavlov]

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 commands/led.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/commands/led.c b/commands/led.c
index 7fd9d44..6bda797 100644
--- a/commands/led.c
+++ b/commands/led.c
@@ -40,7 +40,7 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
 		led = led_by_number(i);
 		if (!led) {
 			printf("no registered LEDs\n");
-			return COMMAND_ERROR;
+			return 1;
 		}
 
 		printf("registered LEDs:\n");
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox