From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: versatilepb board support is broken
Date: Mon, 8 Aug 2011 23:05:36 +0200 [thread overview]
Message-ID: <20110808210536.GB22213@game.jcrosoft.org> (raw)
In-Reply-To: <CAA4bVAHyTDdjUy+xUsKWqXQWwyKh0iX_TTE=fqC=K_jPqZjGEQ@mail.gmail.com>
On 23:49 Mon 08 Aug , Antony Pavlov wrote:
> Hi!
>
> The following patch breaks qemu versatilepb board support:
>
> c0ff8f7f47fa10b2e683cb0452f659c97aec186f
> versatile: switch to add_generic_device
>
> The problem is in serial port initialization.
>
> As versatilepb use only one serial port, this hack make barebox workable
> again (of course it is not a good solution).
>
> --- a/arch/arm/mach-versatile/core.c
> +++ b/arch/arm/mach-versatile/core.c
> @@ -156,6 +156,7 @@ void versatile_register_uart(unsigned id)
> switch (id) {
> case 0:
> start = VERSATILE_UART0_BASE;
I found the issue too
but you need to fix all uart
see my patch
Best Regards,
J.
> + vpb_clk_create(&ref_clk_24, "uart-pl0110");
> break;
> case 1:
> start = VERSATILE_UART1_BASE;
> @@ -171,7 +172,6 @@ void versatile_register_uart(unsigned id)
> }
> dev = add_generic_device("uart-pl011", id, NULL, start, 4096,
> IORESOURCE_MEM, NULL);
> - vpb_clk_create(&ref_clk_24, dev_name(dev));
> }
>
> void __noreturn reset_cpu (unsigned long ignored)
>
> --
> Best regards,
> Antony Pavlov
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-08-08 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 19:49 Antony Pavlov
2011-08-08 21:05 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-08-10 11:22 ` Antony Pavlov
2011-08-10 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808210536.GB22213@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox