From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] imx_spi: drop non usefull ifdef
Date: Fri, 12 Aug 2011 14:10:44 +0200 [thread overview]
Message-ID: <20110812121044.GO31404@pengutronix.de> (raw)
In-Reply-To: <20110812093635.GB1916@game.jcrosoft.org>
On Fri, Aug 12, 2011 at 11:36:35AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:42 Fri 12 Aug , Sascha Hauer wrote:
> > On Thu, Aug 11, 2011 at 05:55:24PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > drop CONFIG_DRIVER_SPI_IMX_<version>
> > >
> > > + if (cpu_is_mx51() || cpu_is_mx53()) {
> > > + imx->chipselect = cspi_2_3_chipselect;
> > > + imx->xchg_single = cspi_2_3_xchg_single;
> > > + imx->init = cspi_2_3_init;
> > > + }
> >
> > Please keep structs to the SoC specific data. We might want to add
> > device tree support in the future, then we'll need pointers to
> > SoC specific data.
>
> DT in barebox?
>
> So so it will increase the size a lot not sure it's really usefull
We'll need limited device tree support anyway soon. When Shawn continues
I won't be able to boot my boards soon without OF. Then I at least want
to be able to adjust the command line (which is embedded in the device
tree)
Of course this adds to the binary size, but it's not huge. I'm currently
experimenting with this and so far it looks promising. Anyway, it will
be completely optional for people who don't want it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-08-12 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 15:30 [PATCH] imx_spi: drop non usefull ifdef enum imx_spi_devtype and arround cpu_is_xx Jean-Christophe PLAGNIOL-VILLARD
2011-08-11 15:55 ` [PATCH v2] imx_spi: drop non usefull ifdef Jean-Christophe PLAGNIOL-VILLARD
2011-08-12 6:42 ` Sascha Hauer
2011-08-12 9:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-12 12:10 ` Sascha Hauer [this message]
2011-08-12 12:49 ` Jean-Christophe PLAGNIOL-VILLARD
2011-08-12 17:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812121044.GO31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox