Re: [PATCH v2] imx_spi: drop non usefull ifdef

[Sascha Hauer <s.hauer@pengutronix.de>]

On Fri, Aug 12, 2011 at 02:49:21PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:10 Fri 12 Aug     , Sascha Hauer wrote:
> > On Fri, Aug 12, 2011 at 11:36:35AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 08:42 Fri 12 Aug     , Sascha Hauer wrote:
> > > > On Thu, Aug 11, 2011 at 05:55:24PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > > drop CONFIG_DRIVER_SPI_IMX_<version>
> > > > > 
> > > > > +	if (cpu_is_mx51() || cpu_is_mx53()) {
> > > > > +		imx->chipselect = cspi_2_3_chipselect;
> > > > > +		imx->xchg_single = cspi_2_3_xchg_single;
> > > > > +		imx->init = cspi_2_3_init;
> > > > > +	}
> > > > 
> > > > Please keep structs to the SoC specific data. We might want to add
> > > > device tree support in the future, then we'll need pointers to
> > > > SoC specific data.
> > > 
> > > DT in barebox?
> > > 
> > > So so it will increase the size a lot not sure it's really usefull
> > 
> > We'll need limited device tree support anyway soon. When Shawn continues
> > I won't be able to boot my boards soon without OF. Then I at least want
> > to be able to adjust the command line (which is embedded in the device
> > tree)
> > 
> > Of course this adds to the binary size, but it's not huge. I'm currently
> > experimenting with this and so far it looks promising. Anyway, it will
> > be completely optional for people who don't want it.
> I take a look too but my key point is do we nned the DT for internal use

No we don't. But then again, in the dt there is also the description for
nand/nor partitions and maybe MAC addresses. It's quite painful to keep
these in sync with barebox when there's no association between the
device tree and the barebox devices.
I think the most additional code for is needed to be able to get basic OF
suppport (dump the tree, update bootargs and memory parameters).
Integrating it fully into barebox is only a small step then.

But let's see, as said, I'm in early experimental stage.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox