mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata)
@ 2011-08-23 12:21 Tim Sander
  2011-08-23 12:53 ` Sascha Hauer
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Tim Sander @ 2011-08-23 12:21 UTC (permalink / raw)
  To: barebox

Hi

I just found out that Phytec has some patches in its BSP and i think especially the patches
IM590_cfi_workaround for "Numonyx Axcell P33/P30 Specification Update" make me a little nervous.

We had some Problems getting the latest HW Revision of PCM043 (1315.6) up and
running and so i found these patches. I have ported some other patches i found
(which i will send later today) but i don't know enough about CFI to apply this patch
logically to the barebox tree nevertheless heres my educated guess:
(I am not sure if the patch belongs into intel CFI but since Numonyx has been owned by
intel partly...)

commit bfa486c0bd90055222b4a2702bfb0d6a0fe59d8e
Author: Tim Sander <tim.sander@hbm.com>
Date:   Tue Aug 23 14:03:49 2011 +0200

    IM590 cfi workaround

diff --git a/drivers/nor/cfi_flash_intel.c b/drivers/nor/cfi_flash_intel.c
index c3cbad5..30a54e6 100644
--- a/drivers/nor/cfi_flash_intel.c
+++ b/drivers/nor/cfi_flash_intel.c
@@ -132,12 +132,30 @@ static int intel_flash_status_check (struct flash_info *info, flash_sect_t secto
 static int intel_flash_real_protect (struct flash_info *info, long sector, int prot)
 {
        flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
+       //flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
+       /*
+       * see errata called
+       * "Numonyx Axcell P33/P30 Specification Update" :)
+       */
+       flash_write_cmd (info, sector, 0, FLASH_CMD_READ_ID);
+       flash_isequal (info, sector, FLASH_OFFSET_PROTECT, prot);
+       /*
+       * cmd must come before FLASH_CMD_PROTECT + 20us
+       * Disable interrupts which might cause a timeout here.
+       */
+#ifdef CONFIG_USE_IRQ
+       int flag = disable_interrupts ();
+#endif
        flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
        if (prot)
                flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_SET);
        else
                flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
-
+       
+#ifdef CONFIG_USE_IRQ
+       if(flag)
+               enable_interrupts();
+#endif
        return 0;
 }


This patch is against u-boot-v2-rc10 *not* againts barebox as reference. It is taken from the 
PD10.1.2 BSP for PCM043.
Index: u-boot-2.0.0-rc10/drivers/nor/cfi_flash.c        
===================================================================
--- u-boot-2.0.0-rc10.orig/drivers/nor/cfi_flash.c  2011-01-28 10:52:14.881458149 +0100
+++ u-boot-2.0.0-rc10/drivers/nor/cfi_flash.c   2011-01-28 11:09:40.241981535 +0100
@@ -599,14 +599,34 @@
 static int flash_real_protect (flash_info_t * info, long sector, int prot)
 {
    int retcode = 0;
+   unsigned short cmd;

    flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
-   flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
+   /*
+    * see errata called
+    * "Numonyx Axcell P33/P30 Specification Update" :)
+    */
+   flash_write_cmd (info, sector, 0, FLASH_CMD_READ_ID);
+   flash_isequal (info, sector, FLASH_OFFSET_PROTECT, prot);
+   /*
+    * cmd must come before FLASH_CMD_PROTECT + 20us
+    * Disable interrupts which might cause a timeout here.
+    */
+#ifdef CONFIG_USE_IRQ
+   int flag = disable_interrupts ();
+#endif
    if (prot)
-       flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_SET);
+       cmd = FLASH_CMD_PROTECT_SET;
    else
-       flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
+       cmd = FLASH_CMD_PROTECT_CLEAR;

+   flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
+   flash_write_cmd (info, sector, 0, cmd);
+#ifdef CONFIG_USE_IRQ
+   /* re-enable interrupts if necessary */
+   if (flag)
+       enable_interrupts ();
+#endif
    if ((retcode =
         flash_full_status_check (info, sector, info->erase_blk_tout,
                      prot ? "protect" : "unprotect")) == 0) {

--
Please CC as i'm not subscribed to the list.

Best regards
Tim

Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 

Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster

Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster

The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.

Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich fur den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata)
  2011-08-23 12:21 RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata) Tim Sander
@ 2011-08-23 12:53 ` Sascha Hauer
  2011-08-23 13:22 ` Teresa Gamez
       [not found] ` <201108231701.21401.tim.sander@hbm.com>
  2 siblings, 0 replies; 8+ messages in thread
From: Sascha Hauer @ 2011-08-23 12:53 UTC (permalink / raw)
  To: Tim Sander; +Cc: barebox

Teresa,

Can you provide some input to this one?

Sascha

On Tue, Aug 23, 2011 at 02:21:42PM +0200, Tim Sander wrote:
> Hi
> 
> I just found out that Phytec has some patches in its BSP and i think especially the patches
> IM590_cfi_workaround for "Numonyx Axcell P33/P30 Specification Update" make me a little nervous.
> 
> We had some Problems getting the latest HW Revision of PCM043 (1315.6) up and
> running and so i found these patches. I have ported some other patches i found
> (which i will send later today) but i don't know enough about CFI to apply this patch
> logically to the barebox tree nevertheless heres my educated guess:
> (I am not sure if the patch belongs into intel CFI but since Numonyx has been owned by
> intel partly...)
> 
> commit bfa486c0bd90055222b4a2702bfb0d6a0fe59d8e
> Author: Tim Sander <tim.sander@hbm.com>
> Date:   Tue Aug 23 14:03:49 2011 +0200
> 
>     IM590 cfi workaround
> 
> diff --git a/drivers/nor/cfi_flash_intel.c b/drivers/nor/cfi_flash_intel.c
> index c3cbad5..30a54e6 100644
> --- a/drivers/nor/cfi_flash_intel.c
> +++ b/drivers/nor/cfi_flash_intel.c
> @@ -132,12 +132,30 @@ static int intel_flash_status_check (struct flash_info *info, flash_sect_t secto
>  static int intel_flash_real_protect (struct flash_info *info, long sector, int prot)
>  {
>         flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
> +       //flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
> +       /*
> +       * see errata called
> +       * "Numonyx Axcell P33/P30 Specification Update" :)
> +       */
> +       flash_write_cmd (info, sector, 0, FLASH_CMD_READ_ID);
> +       flash_isequal (info, sector, FLASH_OFFSET_PROTECT, prot);
> +       /*
> +       * cmd must come before FLASH_CMD_PROTECT + 20us
> +       * Disable interrupts which might cause a timeout here.
> +       */
> +#ifdef CONFIG_USE_IRQ
> +       int flag = disable_interrupts ();
> +#endif
>         flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
>         if (prot)
>                 flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_SET);
>         else
>                 flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
> -
> +       
> +#ifdef CONFIG_USE_IRQ
> +       if(flag)
> +               enable_interrupts();
> +#endif
>         return 0;
>  }
> 
> 
> This patch is against u-boot-v2-rc10 *not* againts barebox as reference. It is taken from the 
> PD10.1.2 BSP for PCM043.
> Index: u-boot-2.0.0-rc10/drivers/nor/cfi_flash.c        
> ===================================================================
> --- u-boot-2.0.0-rc10.orig/drivers/nor/cfi_flash.c  2011-01-28 10:52:14.881458149 +0100
> +++ u-boot-2.0.0-rc10/drivers/nor/cfi_flash.c   2011-01-28 11:09:40.241981535 +0100
> @@ -599,14 +599,34 @@
>  static int flash_real_protect (flash_info_t * info, long sector, int prot)
>  {
>     int retcode = 0;
> +   unsigned short cmd;
> 
>     flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
> -   flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
> +   /*
> +    * see errata called
> +    * "Numonyx Axcell P33/P30 Specification Update" :)
> +    */
> +   flash_write_cmd (info, sector, 0, FLASH_CMD_READ_ID);
> +   flash_isequal (info, sector, FLASH_OFFSET_PROTECT, prot);
> +   /*
> +    * cmd must come before FLASH_CMD_PROTECT + 20us
> +    * Disable interrupts which might cause a timeout here.
> +    */
> +#ifdef CONFIG_USE_IRQ
> +   int flag = disable_interrupts ();
> +#endif
>     if (prot)
> -       flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_SET);
> +       cmd = FLASH_CMD_PROTECT_SET;
>     else
> -       flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
> +       cmd = FLASH_CMD_PROTECT_CLEAR;
> 
> +   flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
> +   flash_write_cmd (info, sector, 0, cmd);
> +#ifdef CONFIG_USE_IRQ
> +   /* re-enable interrupts if necessary */
> +   if (flag)
> +       enable_interrupts ();
> +#endif
>     if ((retcode =
>          flash_full_status_check (info, sector, info->erase_blk_tout,
>                       prot ? "protect" : "unprotect")) == 0) {
> 
> --
> Please CC as i'm not subscribed to the list.
> 
> Best regards
> Tim
> 
> Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 
> 
> Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
> Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster
> 
> Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
> Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster
> 
> The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
> 
> Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich fur den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata)
  2011-08-23 12:21 RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata) Tim Sander
  2011-08-23 12:53 ` Sascha Hauer
@ 2011-08-23 13:22 ` Teresa Gamez
  2011-08-23 14:40   ` Tim Sander
       [not found] ` <201108231701.21401.tim.sander@hbm.com>
  2 siblings, 1 reply; 8+ messages in thread
From: Teresa Gamez @ 2011-08-23 13:22 UTC (permalink / raw)
  To: Tim Sander; +Cc: barebox

Hello Tim,

Am Dienstag, den 23.08.2011, 14:21 +0200 schrieb Tim Sander:
> Hi
> 
> I just found out that Phytec has some patches in its BSP and i think especially the patches
> IM590_cfi_workaround for "Numonyx Axcell P33/P30 Specification Update" make me a little nervous.
> 
> We had some Problems getting the latest HW Revision of PCM043 (1315.6) up and
> running and so i found these patches. I have ported some other patches i found
> (which i will send later today) but i don't know enough about CFI to apply this patch
> logically to the barebox tree nevertheless heres my educated guess:
> (I am not sure if the patch belongs into intel CFI but since Numonyx has been owned by
> intel partly...)

I'm right now working on updating the pcm043 barebox to work with 
new hardware revisions. Including updates for NOR Flash support. 

I have also made a patch quite similar to yours. This problem seems 
to occur only with NOR Flashes having a date code around 39/2010 and earlier.
It took me some time to find a module which does have this problem 
(I just got it today and have not checked it yet). 
On newer NOR Flashes I could not see any affect/advantage with this workaround.
I'll test your patch with this module.

But adding this workaround will not be enough to support newer NOR flashes.
The CS values need to be changed and support for u32 commands have to 
be added to cfi_flash. I'll send patches the next days. 

Teresa

> 
> commit bfa486c0bd90055222b4a2702bfb0d6a0fe59d8e
> Author: Tim Sander <tim.sander@hbm.com>
> Date:   Tue Aug 23 14:03:49 2011 +0200
> 
>     IM590 cfi workaround
> 
> diff --git a/drivers/nor/cfi_flash_intel.c b/drivers/nor/cfi_flash_intel.c
> index c3cbad5..30a54e6 100644
> --- a/drivers/nor/cfi_flash_intel.c
> +++ b/drivers/nor/cfi_flash_intel.c
> @@ -132,12 +132,30 @@ static int intel_flash_status_check (struct flash_info *info, flash_sect_t secto
>  static int intel_flash_real_protect (struct flash_info *info, long sector, int prot)
>  {
>         flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
> +       //flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
> +       /*
> +       * see errata called
> +       * "Numonyx Axcell P33/P30 Specification Update" :)
> +       */
> +       flash_write_cmd (info, sector, 0, FLASH_CMD_READ_ID);
> +       flash_isequal (info, sector, FLASH_OFFSET_PROTECT, prot);
> +       /*
> +       * cmd must come before FLASH_CMD_PROTECT + 20us
> +       * Disable interrupts which might cause a timeout here.
> +       */
> +#ifdef CONFIG_USE_IRQ
> +       int flag = disable_interrupts ();
> +#endif
>         flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
>         if (prot)
>                 flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_SET);
>         else
>                 flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
> -
> +       
> +#ifdef CONFIG_USE_IRQ
> +       if(flag)
> +               enable_interrupts();
> +#endif
>         return 0;
>  }
> 
> 
> This patch is against u-boot-v2-rc10 *not* againts barebox as reference. It is taken from the 
> PD10.1.2 BSP for PCM043.
> Index: u-boot-2.0.0-rc10/drivers/nor/cfi_flash.c        
> ===================================================================
> --- u-boot-2.0.0-rc10.orig/drivers/nor/cfi_flash.c  2011-01-28 10:52:14.881458149 +0100
> +++ u-boot-2.0.0-rc10/drivers/nor/cfi_flash.c   2011-01-28 11:09:40.241981535 +0100
> @@ -599,14 +599,34 @@
>  static int flash_real_protect (flash_info_t * info, long sector, int prot)
>  {
>     int retcode = 0;
> +   unsigned short cmd;
> 
>     flash_write_cmd (info, sector, 0, FLASH_CMD_CLEAR_STATUS);
> -   flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
> +   /*
> +    * see errata called
> +    * "Numonyx Axcell P33/P30 Specification Update" :)
> +    */
> +   flash_write_cmd (info, sector, 0, FLASH_CMD_READ_ID);
> +   flash_isequal (info, sector, FLASH_OFFSET_PROTECT, prot);
> +   /*
> +    * cmd must come before FLASH_CMD_PROTECT + 20us
> +    * Disable interrupts which might cause a timeout here.
> +    */
> +#ifdef CONFIG_USE_IRQ
> +   int flag = disable_interrupts ();
> +#endif
>     if (prot)
> -       flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_SET);
> +       cmd = FLASH_CMD_PROTECT_SET;
>     else
> -       flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT_CLEAR);
> +       cmd = FLASH_CMD_PROTECT_CLEAR;
> 
> +   flash_write_cmd (info, sector, 0, FLASH_CMD_PROTECT);
> +   flash_write_cmd (info, sector, 0, cmd);
> +#ifdef CONFIG_USE_IRQ
> +   /* re-enable interrupts if necessary */
> +   if (flag)
> +       enable_interrupts ();
> +#endif
>     if ((retcode =
>          flash_full_status_check (info, sector, info->erase_blk_tout,
>                       prot ? "protect" : "unprotect")) == 0) {
> 
> --
> Please CC as i'm not subscribed to the list.
> 
> Best regards
> Tim
> 
> Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 
> 
> Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
> Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster
> 
> Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
> Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster
> 
> The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
> 
> Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich fur den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.
> 



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata)
  2011-08-23 13:22 ` Teresa Gamez
@ 2011-08-23 14:40   ` Tim Sander
  2011-08-24  8:54     ` Teresa Gamez
  0 siblings, 1 reply; 8+ messages in thread
From: Tim Sander @ 2011-08-23 14:40 UTC (permalink / raw)
  To: Teresa Gamez; +Cc: barebox

Hi Teresa
> I'm right now working on updating the pcm043 barebox to work with
> new hardware revisions. Including updates for NOR Flash support.
These are good news. 

> I have also made a patch quite similar to yours. This problem seems
> to occur only with NOR Flashes having a date code around 39/2010 and
> earlier. It took me some time to find a module which does have this
> problem (I just got it today and have not checked it yet).
> On newer NOR Flashes I could not see any affect/advantage with this
> workaround. I'll test your patch with this module.
It seems as if we got such a version. I can write partitions with tftp via 
network but i can't do a saveenv even with my patch. So i guess its not
working as i hoped for. I guess since saveenv does an unprotect copy protect
itself it triggers the errata for these nor chips:
cfi_protect: unprotect 0xa0040000 (size 131072)
Flash buffer write error at address a0040000
Command Sequence Error.
cfi_protect: protect 0xa0040000 (size 131072)

> But adding this workaround will not be enough to support newer NOR flashes.
> The CS values need to be changed and support for u32 commands have to
> be added to cfi_flash. I'll send patches the next days.

As for the u32 support, isn't everything in place with:
CONFIG_DRIVER_CFI_BANK_WIDTH_4=y

Do you have some CS values for me to test with?

I've got the impression that writes on the 64Mb nor pcm043 are much faster 
than the old hw revisions with 32Mb nor.

Best regards
Tim

Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 

Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster

Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster

The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.

Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich für den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata)
  2011-08-23 14:40   ` Tim Sander
@ 2011-08-24  8:54     ` Teresa Gamez
  2011-08-24 10:07       ` Tim Sander
  0 siblings, 1 reply; 8+ messages in thread
From: Teresa Gamez @ 2011-08-24  8:54 UTC (permalink / raw)
  To: Tim Sander; +Cc: barebox

Hello Tim,

Am Dienstag, den 23.08.2011, 16:40 +0200 schrieb Tim Sander:
> Hi Teresa
> > I'm right now working on updating the pcm043 barebox to work with
> > new hardware revisions. Including updates for NOR Flash support.
> These are good news. 
> 
> > I have also made a patch quite similar to yours. This problem seems
> > to occur only with NOR Flashes having a date code around 39/2010 and
> > earlier. It took me some time to find a module which does have this
> > problem (I just got it today and have not checked it yet).
> > On newer NOR Flashes I could not see any affect/advantage with this
> > workaround. I'll test your patch with this module.
> It seems as if we got such a version. I can write partitions with tftp via 
> network but i can't do a saveenv even with my patch. So i guess its not
> working as i hoped for. I guess since saveenv does an unprotect copy protect
> itself it triggers the errata for these nor chips:
> cfi_protect: unprotect 0xa0040000 (size 131072)
> Flash buffer write error at address a0040000
> Command Sequence Error.
> cfi_protect: protect 0xa0040000 (size 131072)

If only saving the environment makes you trouble it looks more like
the problem of missing support for u32 commands.
As far as I understand this, the buffer size of the NOR flashes where
highly increased. 8bit for the size of data that can be written to the
buffer is not enough. Since tftp sends the data in smaller packages,
writing still works when flashing kernel/rootfs. But fails when saving
the environment.  

> 
> > But adding this workaround will not be enough to support newer NOR flashes.
> > The CS values need to be changed and support for u32 commands have to
> > be added to cfi_flash. I'll send patches the next days.
> 
> As for the u32 support, isn't everything in place with:
> CONFIG_DRIVER_CFI_BANK_WIDTH_4=y
> 
> Do you have some CS values for me to test with?
> 

Patches follow. Please test them.

Teresa

> I've got the impression that writes on the 64Mb nor pcm043 are much faster 
> than the old hw revisions with 32Mb nor.
> 
> Best regards
> Tim
> 
> Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 
> 
> Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
> Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster
> 
> Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
> Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster
> 
> The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
> 
> Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich für den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.
> 



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata)
  2011-08-24  8:54     ` Teresa Gamez
@ 2011-08-24 10:07       ` Tim Sander
  2011-08-24 12:25         ` Teresa Gamez
  0 siblings, 1 reply; 8+ messages in thread
From: Tim Sander @ 2011-08-24 10:07 UTC (permalink / raw)
  To: Teresa Gamez; +Cc: barebox

Hi Teresa
> If only saving the environment makes you trouble it looks more like
> the problem of missing support for u32 commands.
> As far as I understand this, the buffer size of the NOR flashes where
> highly increased. 8bit for the size of data that can be written to the
> buffer is not enough. Since tftp sends the data in smaller packages,
> writing still works when flashing kernel/rootfs. But fails when saving
> the environment.
Ok, we have a pcm 043 board hw rev. 1315.6 with 64Mb of NOr Flash.
So we have plenty of 1315.4 revs over here with 32Mb which work with
a 2011.04 barebox without problems.

The flash chip is an intel (numonyx?)  512P33TF.

> Patches follow. Please test them.
Will test.

Best regards
Tim

Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 

Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster

Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster

The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.

Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich für den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata)
  2011-08-24 10:07       ` Tim Sander
@ 2011-08-24 12:25         ` Teresa Gamez
  0 siblings, 0 replies; 8+ messages in thread
From: Teresa Gamez @ 2011-08-24 12:25 UTC (permalink / raw)
  To: Tim Sander; +Cc: barebox

Am Mittwoch, den 24.08.2011, 12:07 +0200 schrieb Tim Sander:
> Hi Teresa
> > If only saving the environment makes you trouble it looks more like
> > the problem of missing support for u32 commands.
> > As far as I understand this, the buffer size of the NOR flashes where
> > highly increased. 8bit for the size of data that can be written to the
> > buffer is not enough. Since tftp sends the data in smaller packages,
> > writing still works when flashing kernel/rootfs. But fails when saving
> > the environment.
> Ok, we have a pcm 043 board hw rev. 1315.6 with 64Mb of NOr Flash.
> So we have plenty of 1315.4 revs over here with 32Mb which work with
> a 2011.04 barebox without problems.
> 
> The flash chip is an intel (numonyx?)  512P33TF.

I work with an 32MB NOR Flash (PC28F256P33BFE) which is the standard kit
setup. I don't know of the CS0 settings fit for your flash. 

> 
> > Patches follow. Please test them.
> Will test.

Thanks.

Teresa

> 
> Best regards
> Tim
> 
> Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 
> 
> Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
> Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster
> 
> Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
> Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster
> 
> The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
> 
> Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich für den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.
> 



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Patch test results was (Re: RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata))
       [not found]   ` <1314270042.3389.608.camel@lws-gamez>
@ 2011-08-25 14:57     ` Tim Sander
  0 siblings, 0 replies; 8+ messages in thread
From: Tim Sander @ 2011-08-25 14:57 UTC (permalink / raw)
  To: Teresa Gamez; +Cc: barebox

Hi Teresa
> did the patches help?
Ah i missed these, please CC next time as i'm not on the list.

So these patches get my
Tested-by: Tim Sander <tim.sander@hbm.com>

I am using:
[PATCH] pcm memory fix
http://lists.infradead.org/pipermail/barebox/2011-August/004450.html
needed to get our 1315.6  revision to work.

[PATCH] ARM pcm043: Check silicon revision to set up cpu freq correct
http://lists.infradead.org/pipermail/barebox/2011-August/004438.html
didn't see any effect. 

[PATCH] cfi_flash: support of u32 cmd
http://lists.infradead.org/pipermail/barebox/2011-August/004454.html

[PATCH] ARM pcm043: New NOR Flash CS0 values
http://lists.infradead.org/pipermail/barebox/2011-August/004455.html
it seems as this helps with the new flash chips which are also mounted on our 
1315.4 board revisions. Saveenv works with these boards.

These patches are progress in the right direction. I tested with 1315.2, 
1315.4 and 1315.6. All seem to pass saveenv and flashing our firmware.

Especially the old 1315.2 hw revision had some problems which are also 
resolved with the above patches.

Best regards
Tim

Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 

Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster

Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster

The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.

Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich für den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-08-25 14:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-23 12:21 RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata) Tim Sander
2011-08-23 12:53 ` Sascha Hauer
2011-08-23 13:22 ` Teresa Gamez
2011-08-23 14:40   ` Tim Sander
2011-08-24  8:54     ` Teresa Gamez
2011-08-24 10:07       ` Tim Sander
2011-08-24 12:25         ` Teresa Gamez
     [not found] ` <201108231701.21401.tim.sander@hbm.com>
     [not found]   ` <1314270042.3389.608.camel@lws-gamez>
2011-08-25 14:57     ` Patch test results was (Re: RFC: arm pcm043 1315.6 IM950 timing (Numonyx Axcell Errata)) Tim Sander

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox