From: Sascha Hauer <s.hauer@pengutronix.de>
To: Hubert Feurstein <h.feurstein@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] atmel_mci: handle clk_get error correctly
Date: Mon, 12 Sep 2011 12:28:15 +0200 [thread overview]
Message-ID: <20110912102815.GT31404@pengutronix.de> (raw)
In-Reply-To: <1315568809-17776-2-git-send-email-h.feurstein@gmail.com>
On Fri, Sep 09, 2011 at 01:46:48PM +0200, Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
> drivers/mci/atmel_mci.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mci/atmel_mci.c b/drivers/mci/atmel_mci.c
> index b4489dd..943ab34 100644
> --- a/drivers/mci/atmel_mci.c
> +++ b/drivers/mci/atmel_mci.c
> @@ -23,6 +23,7 @@
> #include <asm/io.h>
> #include <mach/board.h>
> #include <linux/clk.h>
> +#include <linux/err.h>
>
> #include "at91_mci.h"
>
> @@ -460,9 +461,9 @@ static int mci_probe(struct device_d *hw_dev)
> host->hw_dev = hw_dev;
> hw_dev->priv = host;
> host->clk = clk_get(hw_dev, "mci_clk");
> - if (host->clk == NULL) {
> + if (IS_ERR(host->clk)) {
> dev_err(hw_dev, "no mci_clk\n");
> - return -EINVAL;
> + return PTR_ERR(host->clk);
> }
>
> clk_rate = clk_get_rate(host->clk);
Applied 1-3 to next (could have gone to master, but the fixes are
probably not that urgent)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-09-12 10:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 11:46 [PATCH 2/4] macb: handle clk_get error Hubert Feurstein
2011-09-09 11:46 ` [PATCH 3/4] atmel_mci: handle clk_get error correctly Hubert Feurstein
2011-09-12 2:47 ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-12 10:28 ` Sascha Hauer [this message]
2011-09-09 11:46 ` [PATCH 4/4] at91sam9g45: add missing spi clock entries Hubert Feurstein
2011-09-12 2:46 ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-12 21:05 ` [PATCH] at91: add spi fake " Hubert Feurstein
2011-09-13 14:42 ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-13 19:48 ` [PATCH v2] at91: add spi clock connection id entries Hubert Feurstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110912102815.GT31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=h.feurstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox