From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usb.c: warning on USB_MAXINTERFACES overflow
Date: Tue, 13 Sep 2011 09:32:29 +0200 [thread overview]
Message-ID: <20110913073229.GW31404@pengutronix.de> (raw)
In-Reply-To: <1315823146-11632-1-git-send-email-antonynpavlov@gmail.com>
On Mon, Sep 12, 2011 at 02:25:46PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied to master.
Sascha
> ---
> drivers/usb/core/usb.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
> index b01a797..5dc8afe 100644
> --- a/drivers/usb/core/usb.c
> +++ b/drivers/usb/core/usb.c
> @@ -207,6 +207,16 @@ static int usb_parse_config(struct usb_device *dev, unsigned char *buffer, int c
> &buffer[index])->bInterfaceNumber != curr_if_num) {
> /* this is a new interface, copy new desc */
> ifno = dev->config.no_of_if;
> + /* if ifno > USB_MAXINTERFACES, then
> + * next memcpy() will corrupt dev->config
> + */
> + if (ifno > USB_MAXINTERFACES) {
> + printf("ifno = %d > "
> + "USB_MAXINTERFACES = %d !\n",
> + ifno,
> + USB_MAXINTERFACES);
> + break;
> + }
> dev->config.no_of_if++;
> memcpy(&dev->config.if_desc[ifno],
> &buffer[index], buffer[index]);
> --
> 1.7.5.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-09-13 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 10:25 Antony Pavlov
2011-09-13 7:32 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913073229.GW31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox