From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ehci-hcd.c: handle EHCI_HAS_TT in ehci_reset() during startup
Date: Tue, 13 Sep 2011 09:34:19 +0200 [thread overview]
Message-ID: <20110913073419.GX31404@pengutronix.de> (raw)
In-Reply-To: <1315823160-11664-1-git-send-email-antonynpavlov@gmail.com>
On Mon, Sep 12, 2011 at 02:26:00PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> drivers/usb/host/ehci-hcd.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 60fc181..883dc07 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -921,15 +921,10 @@ static int ehci_probe(struct device_d *dev)
> host->submit_control_msg = submit_control_msg;
> host->submit_bulk_msg = submit_bulk_msg;
>
> - if (ehci->flags & EHCI_HAS_TT) {
> - /* Set to host mode */
> - reg = ehci_readl(ehci->hcor + USBMODE);
> - reg |= USBMODE_CM_HC;
> - writel(reg, ehci->hcor + USBMODE);
> - }
> -
> usb_register_host(host);
>
> + ehci_reset(ehci);
> +
ehci_reset is called from ehci_init. Isn't that enough or do we have to
call it explicitely here?
Sascha
> reg = HC_VERSION(ehci_readl(&ehci->hccr->cr_capbase));
> dev_info(dev, "USB EHCI %x.%02x\n", reg >> 8, reg & 0xff);
>
> --
> 1.7.5.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-09-13 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 10:26 Antony Pavlov
2011-09-13 7:34 ` Sascha Hauer [this message]
2011-09-13 12:14 ` Antony Pavlov
2011-09-13 17:04 ` Antony Pavlov
2011-09-16 6:04 Antony Pavlov
2011-09-19 9:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913073419.GX31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox