From: Sascha Hauer <s.hauer@pengutronix.de>
To: Paul Fertser <fercerpav@gmail.com>
Cc: barebox@lists.infradead.org, Franck JULLIEN <elec4fun@gmail.com>
Subject: Re: [PATCH 1/2] m25p80: add additional sanity checks for erasure
Date: Tue, 20 Sep 2011 21:31:21 +0200 [thread overview]
Message-ID: <20110920193121.GA31404@pengutronix.de> (raw)
In-Reply-To: <560194a56016e7562eb1e50f68a58ff6f6e069a7.1316086518.git.fercerpav@gmail.com>
On Thu, Sep 15, 2011 at 03:27:36PM +0400, Paul Fertser wrote:
> This guards for the cases where the initial offset or byte count is
> not aligned with regard to erase block size, thus making it impossible
> for erase to do any harm to the nearby sectors.
I'm unsure about this one. The other flash drivers allow to erase areas
which are not eraseblock aligned. Maybe we should instead add a
cdev->erasesize field. Then we can add this check in the generic code
and fix this for all drivers. (I know this won't work for some nor
flashes which have eraseblocks of different size, but this special
case could still be checked in the driver)
Sascha
>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
> ---
> drivers/nor/m25p80.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/nor/m25p80.c b/drivers/nor/m25p80.c
> index e6fe75e..6f650a5 100644
> --- a/drivers/nor/m25p80.c
> +++ b/drivers/nor/m25p80.c
> @@ -206,7 +206,9 @@ static ssize_t m25p80_erase(struct cdev *cdev, size_t count, unsigned long offse
> __func__, "at", (long long)offset, (long long)count);
>
> /* sanity checks */
> - if (offset + count > flash->size)
> + if ((offset + count > flash->size) ||
> + (offset % flash->erasesize) ||
> + ((offset+count) % flash->erasesize))
> return -EINVAL;
>
> addr = offset;
> --
> 1.7.2.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-09-20 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 11:27 Paul Fertser
2011-09-15 11:31 ` [PATCH 2/2] m25p80: use proper erasesize for SECT_4K devices Paul Fertser
2011-09-20 19:31 ` Sascha Hauer [this message]
2011-09-20 20:29 ` [PATCH 1/2] m25p80: add additional sanity checks for erasure Paul Fertser
2011-09-29 10:28 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920193121.GA31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=elec4fun@gmail.com \
--cc=fercerpav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox