mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Paul Fertser <fercerpav@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Franck JULLIEN <elec4fun@gmail.com>
Subject: Re: [PATCH 1/2] m25p80: add additional sanity checks for erasure
Date: Wed, 21 Sep 2011 00:29:01 +0400	[thread overview]
Message-ID: <20110920202901.GS3579@home.lan> (raw)
In-Reply-To: <20110920193121.GA31404@pengutronix.de>

On Tue, Sep 20, 2011 at 09:31:21PM +0200, Sascha Hauer wrote:
> On Thu, Sep 15, 2011 at 03:27:36PM +0400, Paul Fertser wrote:
> > This guards for the cases where the initial offset or byte count is
> > not aligned with regard to erase block size, thus making it impossible
> > for erase to do any harm to the nearby sectors.
> 
> I'm unsure about this one. The other flash drivers allow to erase areas
> which are not eraseblock aligned. Maybe we should instead add a
> cdev->erasesize field. Then we can add this check in the generic code
> and fix this for all drivers.

I guess i was too surprised by seeing an endless loop when i tried to
erase an area of the wrong size (the counter underflowed) to think
about it in a less narrow-minded way, sorry, you're right of course.

Talking about generalisation, shouldn't the m25p80 driver be hooked
into the mtd subsystem to allow running ubi on top of it? By the
cursory look it seems to be doable without much effort.

Another question: should i repost this early (questionable) series you
seem to have missed[1]?

[1] http://lists.infradead.org/pipermail/barebox/2011-August/004483.html
-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav@gmail.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-09-20 20:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 11:27 Paul Fertser
2011-09-15 11:31 ` [PATCH 2/2] m25p80: use proper erasesize for SECT_4K devices Paul Fertser
2011-09-20 19:31 ` [PATCH 1/2] m25p80: add additional sanity checks for erasure Sascha Hauer
2011-09-20 20:29   ` Paul Fertser [this message]
2011-09-29 10:28     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110920202901.GS3579@home.lan \
    --to=fercerpav@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=elec4fun@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox