From: Sascha Hauer <s.hauer@pengutronix.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] S3C24xx/GPIO: Fix compile time warning
Date: Wed, 28 Sep 2011 13:53:16 +0200 [thread overview]
Message-ID: <20110928115316.GX31404@pengutronix.de> (raw)
In-Reply-To: <201109281212.10811.jbe@pengutronix.de>
Hi Jürgen,
On Wed, Sep 28, 2011 at 12:12:10PM +0200, Juergen Beisert wrote:
> Without this patch the compiler spits a warning:
>
> arch/arm/mach-s3c24xx/gpio-s3c24x0.c: In function 'gpio_is_valid':
> arch/arm/mach-s3c24xx/gpio-s3c24x0.c:176:11: warning: unused variable 'reg'
> arch/arm/mach-s3c24xx/gpio-s3c24x0.c:174:11: warning: unused variable 'bit'
>
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
>
> ---
> arch/arm/mach-s3c24xx/gpio-s3c24x0.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: barebox-git/arch/arm/mach-s3c24xx/gpio-s3c24x0.c
> ===================================================================
> --- barebox-git.orig/arch/arm/mach-s3c24xx/gpio-s3c24x0.c
> +++ barebox-git/arch/arm/mach-s3c24xx/gpio-s3c24x0.c
> @@ -170,9 +170,7 @@ void s3c_gpio_mode(unsigned gpio_mode)
> int gpio_is_valid(int gpio)
> {
> unsigned group = gpio >> 5;
> - unsigned bit = gpio % 32;
> unsigned offset;
> - uint32_t reg;
Both patches do not apply. We do not have a gpio_is_valid() function
in this file.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-09-28 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 10:08 [PATCH] S3C24xx/GPIO: Clean up formatting Juergen Beisert
2011-09-28 10:12 ` [PATCH] S3C24xx/GPIO: Fix compile time warning Juergen Beisert
2011-09-28 11:53 ` Sascha Hauer [this message]
2011-09-28 12:04 ` Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110928115316.GX31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox