mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] S3C24xx/GPIO: Fix compile time warning
Date: Wed, 28 Sep 2011 12:12:10 +0200	[thread overview]
Message-ID: <201109281212.10811.jbe@pengutronix.de> (raw)
In-Reply-To: <201109281208.11561.jbe@pengutronix.de>

Without this patch the compiler spits a warning:

arch/arm/mach-s3c24xx/gpio-s3c24x0.c: In function 'gpio_is_valid':
arch/arm/mach-s3c24xx/gpio-s3c24x0.c:176:11: warning: unused variable 'reg'
arch/arm/mach-s3c24xx/gpio-s3c24x0.c:174:11: warning: unused variable 'bit'

Signed-off-by: Juergen Beisert <jbe@pengutronix.de>

---
 arch/arm/mach-s3c24xx/gpio-s3c24x0.c |    2 --
 1 file changed, 2 deletions(-)

Index: barebox-git/arch/arm/mach-s3c24xx/gpio-s3c24x0.c
===================================================================
--- barebox-git.orig/arch/arm/mach-s3c24xx/gpio-s3c24x0.c
+++ barebox-git/arch/arm/mach-s3c24xx/gpio-s3c24x0.c
@@ -170,9 +170,7 @@ void s3c_gpio_mode(unsigned gpio_mode)
 int gpio_is_valid(int gpio)
 {
 	unsigned group = gpio >> 5;
-	unsigned bit = gpio % 32;
 	unsigned offset;
-	uint32_t reg;
 
 	offset = group_offset[group];
 

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-5121-206917-5128 |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-09-28 10:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 10:08 [PATCH] S3C24xx/GPIO: Clean up formatting Juergen Beisert
2011-09-28 10:12 ` Juergen Beisert [this message]
2011-09-28 11:53   ` [PATCH] S3C24xx/GPIO: Fix compile time warning Sascha Hauer
2011-09-28 12:04     ` Juergen Beisert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109281212.10811.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox