From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH 5/6] toshiba-ac100: add USB host support
Date: Thu, 6 Oct 2011 13:05:50 +0200 [thread overview]
Message-ID: <20111006110550.GV31404@pengutronix.de> (raw)
In-Reply-To: <1317305076-3334-6-git-send-email-antonynpavlov@gmail.com>
On Thu, Sep 29, 2011 at 06:04:35PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> arch/arm/boards/toshiba-ac100/board.c | 18 ++++++++++++++++++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boards/toshiba-ac100/board.c b/arch/arm/boards/toshiba-ac100/board.c
> index e3a5eba..3fd720d 100644
> --- a/arch/arm/boards/toshiba-ac100/board.c
> +++ b/arch/arm/boards/toshiba-ac100/board.c
> @@ -24,6 +24,8 @@
> #include <init.h>
> #include <asm/armlinux.h>
> #include <sizes.h>
> +#include <usb/ehci.h>
> +#include <mach/iomap.h>
>
> static int ac100_mem_init(void)
> {
> @@ -32,3 +34,19 @@ static int ac100_mem_init(void)
> return 0;
> }
> mem_initcall(ac100_mem_init);
> +
> +#ifdef CONFIG_USB_EHCI
> +static struct ehci_platform_data ehci_pdata = {
> + .flags = EHCI_HAS_TT,
> +};
> +#endif
> +
> +static int ac100_devices_init(void)
> +{
> +#ifdef CONFIG_USB_EHCI
> + add_generic_usb_ehci_device(-1, TEGRA_USB3_BASE, &ehci_pdata);
> +#endif
Can we skip the ifdefs? I think the few additional bytes do not
outweigh better readability of the source code.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-10-06 11:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 14:04 [RFC PATCH 0/6] ARM: initial Tegra support Antony Pavlov
2011-09-29 14:04 ` [RFC PATCH 1/6] " Antony Pavlov
2011-09-29 14:04 ` [RFC PATCH 2/6] dirty hack, fixme: disable mmu_cache_flush in arch/arm/cpu/start.c for Tegra Antony Pavlov
2011-10-06 11:07 ` Sascha Hauer
2011-09-29 14:04 ` [RFC PATCH 3/6] ARM: Tegra: add Toshiba AC100 support Antony Pavlov
2011-09-29 14:04 ` [RFC PATCH 4/6] arm: cpuinfo: Cortex-A9 dirty hack Antony Pavlov
2011-10-06 11:04 ` Sascha Hauer
2011-10-06 18:32 ` Antony Pavlov
2011-09-29 14:04 ` [RFC PATCH 5/6] toshiba-ac100: add USB host support Antony Pavlov
2011-10-06 11:05 ` Sascha Hauer [this message]
2011-09-29 14:04 ` [RFC PATCH 6/6] toshiba-ac100_defconfig update: enable USB-related stuff Antony Pavlov
2011-10-06 11:06 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006110550.GV31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox