From: Sascha Hauer <s.hauer@pengutronix.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH for next] 'bootz' command fails to load the zImage's header
Date: Fri, 14 Oct 2011 14:16:52 +0200 [thread overview]
Message-ID: <20111014121652.GG13898@pengutronix.de> (raw)
In-Reply-To: <201110141411.28523.jbe@pengutronix.de>
On Fri, Oct 14, 2011 at 02:11:28PM +0200, Juergen Beisert wrote:
> Running the 'bootz' command always fails with
>
> could not read <some file>
>
> due to it loads only a size of a pointer, instead of the size of the expected
> header structure.
Applied to master instead which also has this bug. Unfortunately this
bug is also in the october release.
Sascha
>
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
>
> diff --git a/arch/arm/lib/bootz.c b/arch/arm/lib/bootz.c
> index fc14487..9be615b 100644
> --- a/arch/arm/lib/bootz.c
> +++ b/arch/arm/lib/bootz.c
> @@ -53,7 +53,7 @@ static int do_bootz(struct command *cmdtp, int argc, char *argv[])
>
> if (!usemap) {
> header = &__header;
> - ret = read(fd, header, sizeof(header));
> + ret = read(fd, header, sizeof(*header));
> if (ret < sizeof(*header)) {
> printf("could not read %s\n", argv[1]);
> goto err_out;
>
> --
> Pengutronix e.K. | Juergen Beisert |
> Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-10-14 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 12:11 Juergen Beisert
2011-10-14 12:16 ` Sascha Hauer [this message]
2011-10-14 12:37 ` [PATCH for master] Really fix the 'bootz' command Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014121652.GG13898@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox