From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM i.MX27: initialize MAX
Date: Fri, 9 Dec 2011 11:46:31 +0100 [thread overview]
Message-ID: <20111209104631.GN23884@game.jcrosoft.org> (raw)
In-Reply-To: <20111209080652.GY27267@pengutronix.de>
On 09:06 Fri 09 Dec , Sascha Hauer wrote:
> On Thu, Dec 08, 2011 at 03:24:33PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:17 Thu 08 Dec , Sascha Hauer wrote:
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > > arch/arm/mach-imx/imx27.c | 43 +++++++++++++++++++++++++++
> > > arch/arm/mach-imx/include/mach/imx27-regs.h | 1 +
> > > 2 files changed, 44 insertions(+), 0 deletions(-)
> > do we really need this in barebox?
>
> Why not? It's basically just a handfull of register accesses which are
> normally hidden in lowlevel_init without anybody noticing it. The fact
> that I created defines for them just makes it slightly more visible.
can we have a small comment when they are needed at list
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-12-09 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 9:17 Sascha Hauer
2011-12-08 14:24 ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-09 8:06 ` Sascha Hauer
2011-12-09 10:46 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-12-09 11:29 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209104631.GN23884@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox