From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/6] CPUIMX51: add ARM errata and enable L2 cache
Date: Tue, 13 Dec 2011 10:42:41 +0100 [thread overview]
Message-ID: <20111213094241.GD27267@pengutronix.de> (raw)
In-Reply-To: <1323724779-370-3-git-send-email-eric@eukrea.com>
Hi Eric,
On Mon, Dec 12, 2011 at 10:19:36PM +0100, Eric Bénard wrote:
> - add ARM errata ID #468414
> - enable L2 cache to get better performances
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> arch/arm/boards/eukrea_cpuimx51/lowlevel_init.S | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boards/eukrea_cpuimx51/lowlevel_init.S b/arch/arm/boards/eukrea_cpuimx51/lowlevel_init.S
> index 0b3726f..ee3b0fc 100644
> --- a/arch/arm/boards/eukrea_cpuimx51/lowlevel_init.S
> +++ b/arch/arm/boards/eukrea_cpuimx51/lowlevel_init.S
At the moment arch/arm/boards/eukrea_cpuimx51/lowlevel_init.S and
./arch/arm/boards/freescale-mx51-pdk/lowlevel_init.S are exact copies.
What is being done first in board_init_lowlevel is
- workaround the errata
- configure aux control reg
- dis/enable L2 cache
This is basically the same as being done in mx53_init_lowlevel().
Can we instead add a mx5_init_lowlevel which contains the L2 cache
setting and is called from both mx51_init_lowlevel and mx53_lowlevel?
Sascha
> @@ -57,6 +57,11 @@
> board_init_lowlevel:
> mov r10, lr
>
> + /* ARM errata ID #468414 */
> + mrc 15, 0, r1, c1, c0, 1
> + orr r1, r1, #(1 << 5) /* enable L1NEON bit */
> + mcr 15, 0, r1, c1, c0, 1
> +
> /* explicitly disable L2 cache */
> mrc 15, 0, r0, c1, c0, 1
> bic r0, r0, #0x2
> @@ -76,6 +81,11 @@ board_init_lowlevel:
>
> mcr 15, 1, r0, c9, c0, 2
>
> + /* enable L2 cache */
> + mrc 15, 0, r0, c1, c0, 1
> + orr r0, r0, #2
> + mcr 15, 0, r0, c1, c0, 1
> +
> ldr r0, =MX51_CCM_BASE_ADDR
>
> /* Gate of clocks to the peripherals first */
> --
> 1.7.6.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-12-13 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 21:19 [PATCH 1/6] i.MX25: fix LD16 & LD17 iomux Eric Bénard
2011-12-12 21:19 ` [PATCH 2/6] CPUIMX35: enable the watchdog clock asap Eric Bénard
2011-12-12 21:19 ` [PATCH 3/6] CPUIMX51: add ARM errata and enable L2 cache Eric Bénard
2011-12-13 9:42 ` Sascha Hauer [this message]
2011-12-12 21:19 ` [PATCH 4/6] CPUIMX51: fix environement Eric Bénard
2011-12-12 21:19 ` [PATCH 5/6] CPUIMX51: configure SD1 iomux when ESDHC is enabled Eric Bénard
2011-12-12 21:19 ` [PATCH 6/6] CPUIMX51: update defconfig Eric Bénard
2011-12-13 9:44 ` [PATCH 1/6] i.MX25: fix LD16 & LD17 iomux Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213094241.GD27267@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox