mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] at91: add udc usb device controller support
Date: Tue, 13 Dec 2011 11:37:07 +0100	[thread overview]
Message-ID: <20111213103707.GM27267@pengutronix.de> (raw)
In-Reply-To: <1323701217-26236-2-git-send-email-plagnioj@jcrosoft.com>

On Mon, Dec 12, 2011 at 03:46:55PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  arch/arm/mach-at91/include/mach/board.h |   10 +
>  drivers/usb/gadget/Kconfig              |    7 +
>  drivers/usb/gadget/Makefile             |    1 +
>  drivers/usb/gadget/at91_udc.c           | 1513 +++++++++++++++++++++++++++++++
>  drivers/usb/gadget/at91_udc.h           |  167 ++++
>  5 files changed, 1698 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/gadget/at91_udc.c
>  create mode 100644 drivers/usb/gadget/at91_udc.h
> 

[...]

> +
> +/*-------------------------------------------------------------------------*/
> +
> +#ifdef VERBOSE_DEBUG
> +#    define VDBG		DBG
> +#else
> +#    define VDBG(stuff...)	do{}while(0)
> +#endif
> +
> +#ifdef PACKET_TRACE
> +#    define PACKET		VDBG
> +#else
> +#    define PACKET(stuff...)	do{}while(0)
> +#endif
> +
> +#define ERR(stuff...)		pr_err("udc: " stuff)
> +#define WARNING(stuff...)	pr_warning("udc: " stuff)
> +#define INFO(stuff...)		pr_info("udc: " stuff)
> +#define DBG(stuff...)		pr_debug("udc: " stuff)

Please convert to dev_* functions.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-12-13 10:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 14:46 [PATCH 1/4] at91sam9263: fix mci clock Jean-Christophe PLAGNIOL-VILLARD
2011-12-12 14:46 ` [PATCH 2/4] at91: add udc usb device controller support Jean-Christophe PLAGNIOL-VILLARD
2011-12-13 10:37   ` Sascha Hauer [this message]
2011-12-13 15:06   ` [PATCH 2/4 V2] " Jean-Christophe PLAGNIOL-VILLARD
2011-12-12 14:46 ` [PATCH 3/4] at91: add at91_udc resource Jean-Christophe PLAGNIOL-VILLARD
2011-12-14 15:37   ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-12 14:46 ` [PATCH 4/4] usb-a926x: add usb device support Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111213103707.GM27267@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox