mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] Preparation stage to support multiple PPC architectures.
Date: Mon, 2 Jan 2012 12:30:36 +0100	[thread overview]
Message-ID: <20120102113036.GJ27267@pengutronix.de> (raw)
In-Reply-To: <1325157211-3986-2-git-send-email-renaud.barbier@ge.com>

On Thu, Dec 29, 2011 at 11:13:30AM +0000, Renaud Barbier wrote:
> diff --git a/arch/ppc/mach-mpc5xxx/Kconfig b/arch/ppc/mach-mpc5xxx/Kconfig
> index 632fb85..088d07e 100644
> --- a/arch/ppc/mach-mpc5xxx/Kconfig
> +++ b/arch/ppc/mach-mpc5xxx/Kconfig
> @@ -1,3 +1,55 @@
> +if ARCH_MPC5XXX
> +
> +config CLOCKSOURCE_MASK
> +	int
> +	default 32
> +
> +config CLOCKSOURCE_SHIFT
> +	int
> +	default 15

Please no kconfig variable for this. It's easier to just have some SoC
specific include file for this. But please let me first see your 8xxx
patches. arch/ppc/lib/time.c has some (currently unused) #ifdefs and it
might be more appropriate to create a time-8xxx.c (and moving time.c to
time-mpc5200.c) instead of ifdeffing a 75 line file.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-01-02 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-29 11:13 [PATCH 0/2] PPC multiple architecture preparation Renaud Barbier
2011-12-29 11:13 ` [PATCH 1/2] Preparation stage to support multiple PPC architectures Renaud Barbier
2012-01-02 11:30   ` Sascha Hauer [this message]
2011-12-29 11:13 ` [PATCH 2/2] Make clock shift and mask configurable based on the processor type Renaud Barbier
2012-01-02 11:31   ` Sascha Hauer
2012-01-02 11:26 ` [PATCH 0/2] PPC multiple architecture preparation Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120102113036.GJ27267@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=renaud.barbier@ge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox