From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option
Date: Tue, 10 Jan 2012 14:58:55 +0100 [thread overview]
Message-ID: <20120110135855.GT2854@game.jcrosoft.org> (raw)
In-Reply-To: <20120110082739.GQ5446@pengutronix.de>
On 09:27 Tue 10 Jan , Sascha Hauer wrote:
> On Mon, Jan 09, 2012 at 05:33:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 09:37 Mon 09 Jan , Sascha Hauer wrote:
> > > On Sat, Jan 07, 2012 at 10:57:08AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > > ---
> > > > drivers/mtd/nand/atmel_nand.c | 6 ++++++
> > > > 1 files changed, 6 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> > > > index 3213de2..3e00226 100644
> > > > --- a/drivers/mtd/nand/atmel_nand.c
> > > > +++ b/drivers/mtd/nand/atmel_nand.c
> > > > @@ -406,6 +406,12 @@ static int __init atmel_nand_probe(struct device_d *dev)
> > > > }
> > > > }
> > > >
> > > > + if (host->board->on_flash_bbt) {
> > > > + printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
> > >
> > > dev_info?
> > I don't really think it suppose to be here
>
> That's a driver probe function. Why do you think dev_info is not
> suitable here?
the on_flash_bbt is more mtd specific you have nothing to do it the driver
except enable it
so if we put something in dev_info we need to do it in the nand framwork as
it's the same for all the drivers
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-01-10 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 9:57 Jean-Christophe PLAGNIOL-VILLARD
2012-01-09 8:37 ` Sascha Hauer
2012-01-09 16:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-10 8:27 ` Sascha Hauer
2012-01-10 13:58 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110135855.GT2854@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox