From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 3.mo3.mail-out.ovh.net ([46.105.44.175] helo=mo3.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RkcKb-0000g5-9o for barebox@lists.infradead.org; Tue, 10 Jan 2012 14:05:41 +0000 Received: from mail412.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo3.mail-out.ovh.net (Postfix) with SMTP id 7D788100484E for ; Tue, 10 Jan 2012 15:06:57 +0100 (CET) Date: Tue, 10 Jan 2012 14:58:55 +0100 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120110135855.GT2854@game.jcrosoft.org> References: <1325930228-10935-1-git-send-email-plagnioj@jcrosoft.com> <20120109083720.GM5446@pengutronix.de> <20120109163337.GI2854@game.jcrosoft.org> <20120110082739.GQ5446@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120110082739.GQ5446@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option To: Sascha Hauer Cc: barebox@lists.infradead.org On 09:27 Tue 10 Jan , Sascha Hauer wrote: > On Mon, Jan 09, 2012 at 05:33:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 09:37 Mon 09 Jan , Sascha Hauer wrote: > > > On Sat, Jan 07, 2012 at 10:57:08AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > > > --- > > > > drivers/mtd/nand/atmel_nand.c | 6 ++++++ > > > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > > > > index 3213de2..3e00226 100644 > > > > --- a/drivers/mtd/nand/atmel_nand.c > > > > +++ b/drivers/mtd/nand/atmel_nand.c > > > > @@ -406,6 +406,12 @@ static int __init atmel_nand_probe(struct device_d *dev) > > > > } > > > > } > > > > > > > > + if (host->board->on_flash_bbt) { > > > > + printk(KERN_INFO "atmel_nand: Use On Flash BBT\n"); > > > > > > dev_info? > > I don't really think it suppose to be here > > That's a driver probe function. Why do you think dev_info is not > suitable here? the on_flash_bbt is more mtd specific you have nothing to do it the driver except enable it so if we put something in dev_info we need to do it in the nand framwork as it's the same for all the drivers Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox