* [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option
@ 2012-01-07 9:57 Jean-Christophe PLAGNIOL-VILLARD
2012-01-09 8:37 ` Sascha Hauer
0 siblings, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-01-07 9:57 UTC (permalink / raw)
To: barebox
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
drivers/mtd/nand/atmel_nand.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 3213de2..3e00226 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -406,6 +406,12 @@ static int __init atmel_nand_probe(struct device_d *dev)
}
}
+ if (host->board->on_flash_bbt) {
+ printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
+ nand_chip->options |= NAND_USE_FLASH_BBT;
+ }
+
+
/* first scan to find the device and get the page size */
if (nand_scan_ident(mtd, 1)) {
res = -ENXIO;
--
1.7.7
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option
2012-01-07 9:57 [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option Jean-Christophe PLAGNIOL-VILLARD
@ 2012-01-09 8:37 ` Sascha Hauer
2012-01-09 16:33 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2012-01-09 8:37 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Sat, Jan 07, 2012 at 10:57:08AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 3213de2..3e00226 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -406,6 +406,12 @@ static int __init atmel_nand_probe(struct device_d *dev)
> }
> }
>
> + if (host->board->on_flash_bbt) {
> + printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
dev_info?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option
2012-01-09 8:37 ` Sascha Hauer
@ 2012-01-09 16:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-10 8:27 ` Sascha Hauer
0 siblings, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-01-09 16:33 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 09:37 Mon 09 Jan , Sascha Hauer wrote:
> On Sat, Jan 07, 2012 at 10:57:08AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > drivers/mtd/nand/atmel_nand.c | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> > index 3213de2..3e00226 100644
> > --- a/drivers/mtd/nand/atmel_nand.c
> > +++ b/drivers/mtd/nand/atmel_nand.c
> > @@ -406,6 +406,12 @@ static int __init atmel_nand_probe(struct device_d *dev)
> > }
> > }
> >
> > + if (host->board->on_flash_bbt) {
> > + printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
>
> dev_info?
I don't really think it suppose to be here
in the mtd and core
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option
2012-01-09 16:33 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2012-01-10 8:27 ` Sascha Hauer
2012-01-10 13:58 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2012-01-10 8:27 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Mon, Jan 09, 2012 at 05:33:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 09:37 Mon 09 Jan , Sascha Hauer wrote:
> > On Sat, Jan 07, 2012 at 10:57:08AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > ---
> > > drivers/mtd/nand/atmel_nand.c | 6 ++++++
> > > 1 files changed, 6 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> > > index 3213de2..3e00226 100644
> > > --- a/drivers/mtd/nand/atmel_nand.c
> > > +++ b/drivers/mtd/nand/atmel_nand.c
> > > @@ -406,6 +406,12 @@ static int __init atmel_nand_probe(struct device_d *dev)
> > > }
> > > }
> > >
> > > + if (host->board->on_flash_bbt) {
> > > + printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
> >
> > dev_info?
> I don't really think it suppose to be here
That's a driver probe function. Why do you think dev_info is not
suitable here?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option
2012-01-10 8:27 ` Sascha Hauer
@ 2012-01-10 13:58 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-01-10 13:58 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 09:27 Tue 10 Jan , Sascha Hauer wrote:
> On Mon, Jan 09, 2012 at 05:33:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 09:37 Mon 09 Jan , Sascha Hauer wrote:
> > > On Sat, Jan 07, 2012 at 10:57:08AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > > ---
> > > > drivers/mtd/nand/atmel_nand.c | 6 ++++++
> > > > 1 files changed, 6 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> > > > index 3213de2..3e00226 100644
> > > > --- a/drivers/mtd/nand/atmel_nand.c
> > > > +++ b/drivers/mtd/nand/atmel_nand.c
> > > > @@ -406,6 +406,12 @@ static int __init atmel_nand_probe(struct device_d *dev)
> > > > }
> > > > }
> > > >
> > > > + if (host->board->on_flash_bbt) {
> > > > + printk(KERN_INFO "atmel_nand: Use On Flash BBT\n");
> > >
> > > dev_info?
> > I don't really think it suppose to be here
>
> That's a driver probe function. Why do you think dev_info is not
> suitable here?
the on_flash_bbt is more mtd specific you have nothing to do it the driver
except enable it
so if we put something in dev_info we need to do it in the nand framwork as
it's the same for all the drivers
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-10 14:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-07 9:57 [RESEND PATCH] atmel_nand: add on_flash_btt option to enable bbt option Jean-Christophe PLAGNIOL-VILLARD
2012-01-09 8:37 ` Sascha Hauer
2012-01-09 16:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-10 8:27 ` Sascha Hauer
2012-01-10 13:58 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox