Re: [PATCH 2/7] mfd: add mc34708 driver

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Feb 21, 2012 at 04:38:56PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:35 Tue 21 Feb     , Eric Bénard wrote:
> > Le Tue, 21 Feb 2012 15:10:11 +0100,
> > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> > > I still don't like the idea to export it
> > > 
> > > You need a proper API to manage the PMIC
> > > 
> > > so for today no need of this and I doubt the API will need it
> > > 
> > for today we have what is inside barebox and this patche is coherent
> > with what is actually inside barebox (please check other drivers in mfd
> > and mx35-3stack for example).
> > For the future we may no more need this if we have a proper PMIC API
> > but as this API actually is not written, this patchset makes sense.
> today you do not need it
> 
> today you just need to known it the chip is here
> 
> so just check if the devfs is present
> 

Don't know where your problem is with exporting it. Yes, it supports
only a single pmic, but that's all we have on the boards I know. And
this function can be used to modify registers on the pmic, some boards
need this. The day might come when we need some regulator API, but we
are not there and often enough getting a board to run properly is just
'modify this damn bit in the pmic'

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox