From: Sascha Hauer <s.hauer@pengutronix.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: serial S3: fix local structure malloc
Date: Tue, 13 Mar 2012 13:24:06 +0100 [thread overview]
Message-ID: <20120313122406.GW3852@pengutronix.de> (raw)
In-Reply-To: <201203121457.59975.jbe@pengutronix.de>
On Mon, Mar 12, 2012 at 02:57:59PM +0100, Juergen Beisert wrote:
> Patch 2c5404651091e985c9009aa417d80fdaf50d7a68 introduces a private structure
> for the S3C based UARTs but still reserves the memory for the smaller
> structure which fails at runtime.
>
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
Applied to master, thanks
Sascha
>
> diff --git a/drivers/serial/serial_s3c.c b/drivers/serial/serial_s3c.c
> index a5fd4ee..2bdc1df 100644
> --- a/drivers/serial/serial_s3c.c
> +++ b/drivers/serial/serial_s3c.c
> @@ -153,7 +153,7 @@ static int s3c_serial_probe(struct device_d *dev)
> struct s3c_uart *priv;
> struct console_device *cdev;
>
> - priv = xzalloc(sizeof(struct console_device));
> + priv = xzalloc(sizeof(struct s3c_uart));
> cdev = &priv->cdev;
> priv->regs = dev_request_mem_region(dev, 0);
> dev->priv = priv;
>
> --
> Pengutronix e.K. | Juergen Beisert |
> Linux Solutions for Science and Industry | Phone: +49-5121-206917-5128 |
> Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-03-13 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 13:57 Juergen Beisert
2012-03-13 12:24 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313122406.GW3852@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox