From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] i.MX27: Add support for SDHC1
Date: Sun, 18 Mar 2012 16:12:42 +0100 [thread overview]
Message-ID: <20120318151242.GP3852@pengutronix.de> (raw)
In-Reply-To: <1332052180-2707-1-git-send-email-shc_work@mail.ru>
On Sun, Mar 18, 2012 at 10:29:40AM +0400, Alexander Shiyan wrote:
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
This deserves a bit more explanation, like:
imx27_add_mmc0 really registered IMX_SDHC2. Fix this by adding a
imx27_add_mmc1 and use this in the pca100 board file.
Sascha
> ---
> arch/arm/boards/phycard-i.MX27/pca100.c | 2 +-
> arch/arm/mach-imx/include/mach/devices-imx27.h | 7 +++++--
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boards/phycard-i.MX27/pca100.c b/arch/arm/boards/phycard-i.MX27/pca100.c
> index 1b43951..f934a9b 100644
> --- a/arch/arm/boards/phycard-i.MX27/pca100.c
> +++ b/arch/arm/boards/phycard-i.MX27/pca100.c
> @@ -292,7 +292,7 @@ static int pca100_devices_init(void)
>
> imx27_add_nand(&nand_info);
> imx27_add_fec(&fec_info);
> - imx27_add_mmc0(NULL);
> + imx27_add_mmc1(NULL);
> imx27_add_fb(&pca100_fb_data);
>
> PCCR1 |= PCCR1_PERCLK2_EN;
> diff --git a/arch/arm/mach-imx/include/mach/devices-imx27.h b/arch/arm/mach-imx/include/mach/devices-imx27.h
> index 3141d96..4d30200 100644
> --- a/arch/arm/mach-imx/include/mach/devices-imx27.h
> +++ b/arch/arm/mach-imx/include/mach/devices-imx27.h
> @@ -58,7 +58,10 @@ static inline struct device_d *imx27_add_fec(struct fec_platform_data *pdata)
>
> static inline struct device_d *imx27_add_mmc0(void *pdata)
> {
> - return imx_add_mmc((void *)0x10014000, 0, pdata);
> + return imx_add_mmc((void *)IMX_SDHC1_BASE, 0, pdata);
> }
>
> -
> +static inline struct device_d *imx27_add_mmc1(void *pdata)
> +{
> + return imx_add_mmc((void *)IMX_SDHC2_BASE, 1, pdata);
> +}
> --
> 1.7.3.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-03-18 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 6:29 Alexander Shiyan
2012-03-18 15:12 ` Sascha Hauer [this message]
2012-03-20 8:54 ` [PATCH 1/3] i.MX27: Define base address for SDHC1,2,3 Alexander Shiyan
2012-03-20 13:09 ` Sascha Hauer
2012-03-20 8:54 ` [PATCH 2/3] i.MX27: Add support for SDHC1,3 Alexander Shiyan
2012-03-20 8:54 ` [PATCH 3/3] i.MX51: Fix name definition for SSI3 Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120318151242.GP3852@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox