barebox-2012.03.0 imx_get_i2cclk

barebox-2012.03.0 imx_get_i2cclk

[guenter.gebhardt]

[-- Attachment #1.1: Type: text/plain, Size: 999 bytes --]

Hello,

when compiling for a imx53 with i2c enabled i got the following error:

drivers/built-in.o: In function `i2c_imx_set_clk':
/home/ggebhardt/repos/ecuv6_bl/barebox/drivers/i2c/busses/i2c-imx.c:282: 
undefined reference to `imx_get_i2cclk'
make[4]: *** [.tmp_barebox1] Error 1
make[3]: *** [CMakeFiles/bootloader] Error 2
make[2]: *** [CMakeFiles/bootloader.dir/all] Error 2
make[1]: *** [CMakeFiles/bootloader.dir/rule] Error 2
make: *** [bootloader] Error 2

I copied the following from the corresponding imx51 implementation:

diff --git a/barebox/arch/arm/mach-imx/speed-imx53.c 
b/barebox/arch/arm/mach-imx/speed-imx53.c
index 0d6ac24..a168c65 100644
--- a/barebox/arch/arm/mach-imx/speed-imx53.c
+++ b/barebox/arch/arm/mach-imx/speed-imx53.c
@@ -169,6 +169,11 @@ unsigned long imx_get_fecclk(void)
        return imx_get_ipgclk();
 }
 
+unsigned long imx_get_i2cclk(void)
+{
+       return imx_get_ipgclk();
+}
+
 unsigned long imx_get_mmcclk(void)
 {
        u32 reg, prediv, podf, rate;

[-- Attachment #1.2: Type: text/html, Size: 2176 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: barebox-2012.03.0 imx_get_i2cclk

[Sascha Hauer]

On Wed, Mar 21, 2012 at 02:29:18PM +0100, guenter.gebhardt@rafi.de wrote:
> Hello,
> 
> when compiling for a imx53 with i2c enabled i got the following error:
> 
> drivers/built-in.o: In function `i2c_imx_set_clk':
> /home/ggebhardt/repos/ecuv6_bl/barebox/drivers/i2c/busses/i2c-imx.c:282: 
> undefined reference to `imx_get_i2cclk'
> make[4]: *** [.tmp_barebox1] Error 1
> make[3]: *** [CMakeFiles/bootloader] Error 2
> make[2]: *** [CMakeFiles/bootloader.dir/all] Error 2
> make[1]: *** [CMakeFiles/bootloader.dir/rule] Error 2
> make: *** [bootloader] Error 2
> 
> I copied the following from the corresponding imx51 implementation:
> 
> diff --git a/barebox/arch/arm/mach-imx/speed-imx53.c 
> b/barebox/arch/arm/mach-imx/speed-imx53.c
> index 0d6ac24..a168c65 100644
> --- a/barebox/arch/arm/mach-imx/speed-imx53.c
> +++ b/barebox/arch/arm/mach-imx/speed-imx53.c
> @@ -169,6 +169,11 @@ unsigned long imx_get_fecclk(void)
>         return imx_get_ipgclk();
>  }
>  
> +unsigned long imx_get_i2cclk(void)
> +{
> +       return imx_get_ipgclk();
> +}

The patch looks good. Could you create a formal patch with a proper
subject and signed-off-by? 

Sascha

> +
>  unsigned long imx_get_mmcclk(void)
>  {
>         u32 reg, prediv, podf, rate;

> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox