From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 7/8] net: dns: export resolved ip to var resolved_ip
Date: Fri, 30 Mar 2012 12:16:52 +0200 [thread overview]
Message-ID: <20120330101652.GB8116@game.jcrosoft.org> (raw)
In-Reply-To: <20120330091255.GX3852@pengutronix.de>
On 11:12 Fri 30 Mar , Sascha Hauer wrote:
> On Fri, Mar 30, 2012 at 06:31:52AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > This will allow to use it in scripting.
> >
> > {
> > IPaddr_t ip;
> >
> > + setenv("resolved_ip", "");
> > +
> > if (argc != 2)
> > return COMMAND_ERROR_USAGE;
> >
> > @@ -248,6 +251,7 @@ static int do_host(int argc, char *argv[])
> > printf("%s is at ", argv[1]);
> > print_IPaddr(ip);
> > printf("\n");
> > + setenv_ip("resolved_ip", ip);
>
> I smell complex environment scripts here. Maybe we should rather
> integrate dns into getenv_ip. This will help all commands using ip
> addresses instead of putting the burden of resolving a host name into
> the environment.
yeah didn't think about it
not really complex sript but bootp with tftp server with name instead of IP
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-03-30 10:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 4:27 [PATCH 0/8] Network update DHCP/BOOTP Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 4:31 ` [PATCH 1/8] net: dhcp: reset env variable before do a dhcp request Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 4:31 ` [PATCH 2/8] net: dhcp: add support of tftp name server Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 4:31 ` [PATCH 3/8] net: dhcp: add support of tftp server ip or Etherboot file (option 150) Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 9:21 ` Sascha Hauer
2012-03-30 10:14 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-02 10:49 ` Sascha Hauer
2012-04-02 11:18 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 4:31 ` [PATCH 4/8] net: dhcp: allow to set transmitted client id Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 4:31 ` [PATCH 5/8] net: dhcp: allow to set transmitted client uuid Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 4:31 ` [PATCH 6/8] net: dhcp: allow to set transmitted user class Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 4:31 ` [PATCH 7/8] net: dns: export resolved ip to var resolved_ip Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 9:12 ` Sascha Hauer
2012-03-30 10:16 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-03-30 4:31 ` [PATCH 8/8] defaultenv: add support of etherboot_file Jean-Christophe PLAGNIOL-VILLARD
2012-03-30 10:39 ` [PATCH 7/8 v2] net: env: getenv_ip use resolv Jean-Christophe PLAGNIOL-VILLARD
2012-04-02 11:17 ` [PATCH 0/8] Network update DHCP/BOOTP Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330101652.GB8116@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox