From: "Eric Bénard" <eric@eukrea.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] cfi flash: Fix loop count calculation
Date: Tue, 10 Apr 2012 10:38:39 +0200 [thread overview]
Message-ID: <20120410103839.6f7bcef9@eb-e6520> (raw)
In-Reply-To: <1333616355-632-2-git-send-email-s.hauer@pengutronix.de>
Le Thu, 5 Apr 2012 10:59:14 +0200,
Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> 'reduce the number of loops by the width of the port' means
> a simple len / width. Do not try to be clever by shifting
> and doing it wrong.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Tested-by: Eric Bénard <eric@eukrea.com>
> ---
> drivers/nor/cfi_flash_intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nor/cfi_flash_intel.c b/drivers/nor/cfi_flash_intel.c
> index 6318cfe..f0cbf72 100644
> --- a/drivers/nor/cfi_flash_intel.c
> +++ b/drivers/nor/cfi_flash_intel.c
> @@ -68,7 +68,7 @@ static int intel_flash_write_cfibuffer (struct flash_info *info, ulong dest, con
> return retcode;
>
> /* reduce the number of loops by the width of the port */
> - cnt = len >> (info->portwidth - 1);
> + cnt = len / width;
>
> flash_write_cmd(info, sector, 0, (u32)cnt - 1);
> while (cnt-- > 0) {
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-04-10 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 8:59 cfi driver fixes Sascha Hauer
2012-04-05 8:59 ` [PATCH 1/2] cfi flash: Fix loop count calculation Sascha Hauer
2012-04-10 8:38 ` Eric Bénard [this message]
2012-04-05 8:59 ` [PATCH 2/2] cfi flash: Fix alignment problem Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410103839.6f7bcef9@eb-e6520 \
--to=eric@eukrea.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox