Re: [PATCH 6/7] ARM: initial Freescale i.MX6q Armadillo2 support

[Sascha Hauer <s.hauer@pengutronix.de>]

On Sat, Apr 14, 2012 at 12:53:06PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > index 0000000..4b8c52b
> > --- /dev/null
> > +++ b/arch/arm/boards/freescale-mx6-arm2/env/config
> > @@ -0,0 +1,47 @@
> > +#!/bin/sh
> > +
> > +machine=armadillo2
> > +serverip=
> > +user=
> why not set a vendor id and client id to identify the user at dhcp level

Because I don't use this.

> > +
> > +disk_parts="1M(barebox)ro,1M(bareboxenv),4M(kernel),-(root)"
> it will be good to put already a partition for oftree
> 
> 
> btw you use 512k in the c for the env

Why should I store the oftree in a seperate partition?

> > +	.header.length		= cpu_to_be16(32),
> > +	.header.version		= IVT_VERSION,
> > +
> > +	.entry			= APP_DEST + 0x1000,
> > +	.dcd_ptr		= APP_DEST + 0x400 + offsetof(struct imx_flash_header_v2, dcd),
> > +	.boot_data_ptr		= APP_DEST + 0x400 + offsetof(struct imx_flash_header_v2, boot_data),
> > +	.self			= APP_DEST + 0x400,
> > +
> > +	.boot_data.start	= APP_DEST,
> > +	.boot_data.size		= 0x40000,
> why not use barebox_size?

Good catch, will do.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox