From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mo3.mail-out.ovh.net ([178.32.228.3]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SMDZw-0006eP-9b for barebox@lists.infradead.org; Mon, 23 Apr 2012 07:20:56 +0000 Received: from mail622.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo3.mail-out.ovh.net (Postfix) with SMTP id 803A9FFA660 for ; Mon, 23 Apr 2012 09:22:27 +0200 (CEST) Date: Mon, 23 Apr 2012 09:01:21 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120423070121.GN20601@game.jcrosoft.org> References: <20120419053846.GA20601@game.jcrosoft.org> <1334814298-11468-9-git-send-email-plagnioj@jcrosoft.com> <20120423060327.GU3852@pengutronix.de> <20120423062146.GJ20601@game.jcrosoft.org> <20120423070756.GB3852@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120423070756.GB3852@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 09/11] complete: add go and sleep support To: Sascha Hauer Cc: barebox@lists.infradead.org On 09:07 Mon 23 Apr , Sascha Hauer wrote: > On Mon, Apr 23, 2012 at 08:21:46AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 08:03 Mon 23 Apr , Sascha Hauer wrote: > > > > BAREBOX_CMD_START(sleep) > > > > .cmd = do_sleep, > > > > .usage = "delay execution for n seconds", > > > > + BAREBOX_CMD_COMPLETE(cammand_var_complete) > > > > BAREBOX_CMD_END > > > > diff --git a/common/complete.c b/common/complete.c > > > > index 5213b10..9ecce25 100644 > > > > --- a/common/complete.c > > > > +++ b/common/complete.c > > > > @@ -193,6 +193,11 @@ int empty_complete(struct string_list *sl, char *instr) > > > > return 1; > > > > } > > > > > > > > +int cammand_var_complete(struct string_list *sl, char *instr) > > > > +{ > > > > + return 0; > > > > +} > > > > > > Two patches before this one you introduced empty_complete. This function > > > does the same, except that it returns 0 instead of 1. The return value > > > of the complete functions is never checked, so what is going on here? > > > > the return value is checked. > > > > no this different we return 0 as you can use env var complete > > Can you then add a meaningful comment what command cmdtp->complete > should return and what it means? A define instead of using '1' may make > sense aswell. ok will ad any other comment? Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox