From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 1/2] MIPS: start.S: add "barebox" label at _start + 8
Date: Mon, 30 Apr 2012 13:51:30 +0200 [thread overview]
Message-ID: <20120430115130.GC2992@game.jcrosoft.org> (raw)
In-Reply-To: <CAA4bVAE_Q=Fisk0HP7MJ8RgHs3UafwTvUp6TAgp6FdeU+S00bQ@mail.gmail.com>
On 20:04 Sat 28 Apr , Antony Pavlov wrote:
> On 28 April 2012 17:52, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > arch/mips/boot/start.S | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/mips/boot/start.S b/arch/mips/boot/start.S
> > index b756d40..d8f4fd5 100644
> > --- a/arch/mips/boot/start.S
> > +++ b/arch/mips/boot/start.S
> > @@ -52,6 +52,14 @@ _pc: addiu \rd, ra, \label - _pc # label is assumed to be
> > .align 4
> >
> > EXPORT(_start)
> > +
> > + b __start
> > + nop
> > +
> > + .ascii "barebox"
>
> There is the problem with mips64 (thank to Jean-Christophe).
> We must set offset for "barebox" string more explicitly.
>
> I will remake the patches.
I double check by building the malta as 64bit it work but it's true it will be
better to specified the offset explecitly
btw we need to discuss with the kernel ML to add a Magic too in the
vmlinux.bin and vmlinu.bin to be able to detect there type automatically
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-04-30 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 13:52 Antony Pavlov
2012-04-28 13:52 ` [RFC 2/2] MIPS: bootm: add "MIPS barebox" handler Antony Pavlov
2012-04-28 16:04 ` [RFC 1/2] MIPS: start.S: add "barebox" label at _start + 8 Antony Pavlov
2012-04-30 11:51 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120430115130.GC2992@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox