From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH V4 0/4] MPC85xx support
Date: Thu, 3 May 2012 09:12:33 +0200 [thread overview]
Message-ID: <20120503071233.GG4141@pengutronix.de> (raw)
In-Reply-To: <1335864363-18383-1-git-send-email-renaud.barbier@ge.com>
Hi Renaud,
On Tue, May 01, 2012 at 10:25:59AM +0100, Renaud Barbier wrote:
> The patchset V4 introduces the MPC85xx architecture to Barebox and
> addresses the comments of the version 3. The existing PPC code is
> modified to enable multiple PowerPC architecture support.
> All existing architecture specific MPC5xxx code which prevents
> adding additional architectures is moved into the architecture specific
> subdirectories and the PCM030 configuration fixed to use this new
> configuration.
>
> Base MPC85xx infrastructure is added to enable the required
> functionality for a minimal boot target in 32 bit addressing mode
> using an e500v2 core. To address V3 comments global variables that
> helped handling TLBs and LAWs are replaced by search functions.
>
> Finally support is added for a minimal Freescale P2020RDB platform with
> driver support currently limited to NOR and serial port only.
>
> Renaud Barbier (4):
> Preparation stage to support multiple PPC architectures
> Minimal support of the MPC85xx architecture
> Header files update to support the mpc85xx.
> Minimal P2020RDB platform support and configuration file
You might have noticed I applied parts of your patches, namely 1/4 and
the bulk of 3/4. A git rebase should make your patches a bit smaller and
should make you less dependent on future ppc changes.
Generally smaller patches are easier to review and will make merging
your series faster, so it would be nice if you could split this up a bit
more. This is especially important for the parts of the patches that
affect other users like mpc5200 aswell.
Sorry for not replying with a more detailed review, but your patch is
quite big and my spare time is rather small at the moment.
Thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-05-03 7:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 9:25 Renaud Barbier
2012-05-01 9:26 ` [PATCH V4 1/4] Preparation stage to support multiple PPC architectures Renaud Barbier
2012-05-01 9:26 ` [PATCH V4 2/4] Minimal support of the MPC85xx architecture Renaud Barbier
2012-05-01 9:26 ` [PATCH V4 3/4] Header files update to support the mpc85xx Renaud Barbier
2012-05-03 7:13 ` Sascha Hauer
2012-05-01 9:26 ` [PATCH V4 4/4] Minimal P2020RDB platform support and configuration file Renaud Barbier
2012-05-03 7:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503071233.GG4141@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=renaud.barbier@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox