mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Alexey Galakhov <agalakhov@gmail.com>
Subject: Re: [PATCH 2/4] Fine split S3C arch dependencies from generic code
Date: Thu, 3 May 2012 19:41:00 +0200	[thread overview]
Message-ID: <201205031941.00662.jbe@pengutronix.de> (raw)
In-Reply-To: <1336050844-7043-3-git-send-email-agalakhov@gmail.com>

Alexey Galakhov wrote:
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 5c6d8b3..3e211d5 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -14,4 +14,4 @@ obj-$(CONFIG_MTD_NAND_NOMADIK)                += nomadik_nand.o
>  obj-$(CONFIG_NAND_IMX)		+= nand_imx.o 
>  obj-$(CONFIG_NAND_OMAP_GPMC)         += nand_omap_gpmc.o nand_omap_bch_decoder.o
>  obj-$(CONFIG_NAND_ATMEL)             += atmel_nand.o
> -obj-$(CONFIG_NAND_S3C24XX)           += nand_s3c24xx.o
> +obj-$(CONFIG_NAND_S3C)               += nand_s3c.o

> delete mode 100644 drivers/mtd/nand/nand_s3c24xx.c
> create mode 100644 drivers/mtd/nand/nand_s3c.c

> create mode 100644 arch/arm/mach-samsung/include/mach/s3c-nand.h
> delete mode 100644 arch/arm/mach-samsung/include/mach/s3c24xx-nand.h

That is a really bad idea. I just renamed these files at January 2012 to reflect
their CPU (refer b29b8f43d56b62e406349a5cf1ed56f17454c1f7). Why do you revert
this change again? The NAND controller in the S3C24XX CPU is unique to this
CPU. The NAND controller in the S3C6410 differs from it, and I guess the same
is true in the S5 CPU. So, the newer CPUs need their own NAND drivers.

What is the sense of renaming these files?

> create mode 100644 arch/arm/mach-samsung/clocks-s3c24x0.c
> delete mode 100644 arch/arm/mach-samsung/s3c24xx-clocks.c

> create mode 100644 arch/arm/mach-samsung/include/mach/gpio-s3c24x0.h
> delete mode 100644 arch/arm/mach-samsung/include/mach/s3c24xx-gpio.h

This rename _could_ make sense:

> delete mode 100644 arch/arm/mach-samsung/lowlevel-init.S
> create mode 100644 arch/arm/mach-samsung/lowlevel-s3c24x0.S

But on the other hand, this lowlevel init is only required on the S3C24xx
CPUs, as all newer CPUs are coming with an internal ROM (called iROM) and
booting completely different. So, for these CPUs there is no need for such
lowlevel functions.

So sorry, this patch doesn't do a "Fine split".

My b29b8f43d56b62e406349a5cf1ed56f17454c1f7 already separated the S3C24xx
from other Samsung implementations. I think there is no need to touch all
the S3C24xx related files again when adding a new Samsung CPU.

Juergen

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-05-03 17:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03 13:14 [PATCH 0/4] Support Samsung S5PV210 CPU Alexey Galakhov
2012-05-03 13:14 ` [PATCH 1/4] Support most Samsung SoCs in S3C serial driver Alexey Galakhov
2012-05-03 13:14 ` [PATCH 2/4] Fine split S3C arch dependencies from generic code Alexey Galakhov
2012-05-03 17:41   ` Juergen Beisert [this message]
2012-05-04  9:39     ` Alexey Galakhov
2012-05-04  9:58       ` Juergen Beisert
2012-05-04 10:50         ` Alexey Galakhov
2012-05-04 11:13           ` Juergen Beisert
2012-05-04 11:26             ` missing sscanf christian.buettner
2012-05-04 11:40             ` [PATCH 2/4] Fine split S3C arch dependencies from generic code Alexey Galakhov
2012-05-04 12:00               ` Juergen Beisert
2012-05-04 12:34                 ` Alexey Galakhov
2012-05-04 10:52         ` Alexey Galakhov
2012-05-03 13:14 ` [PATCH 3/4] Minimal S5PV210 + Tiny210 support (2nd stage only) Alexey Galakhov
2012-05-03 17:49   ` Juergen Beisert
2012-05-04  9:41     ` Alexey Galakhov
2012-05-03 13:14 ` [PATCH 4/4] S5PV210 iROM magic boot code Alexey Galakhov
2012-05-03 17:59   ` Juergen Beisert
2012-05-04  9:47     ` Alexey Galakhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205031941.00662.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=agalakhov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox