From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] i2c: Added switch for allowing usage 16bit register addresses
Date: Fri, 11 May 2012 20:15:08 +0200 [thread overview]
Message-ID: <20120511181508.GK27341@pengutronix.de> (raw)
In-Reply-To: <1336750939-18572-2-git-send-email-shc_work@mail.ru>
On Fri, May 11, 2012 at 07:42:19PM +0400, Alexander Shiyan wrote:
> ---
> printf("0x%02x ", *(buf + i));
> @@ -135,7 +138,8 @@ static const __maybe_unused char cmd_i2c_write_help[] =
> "write to i2c device.\n"
> " -a 0x<addr> i2c device address\n"
> " -b <bus_num> i2c bus number (default = 0)\n"
> -" -r 0x<reg> start register\n";
> +" -r 0x<reg> start register\n"
> +" -w use the word as an address\n";
Can we have 'do word (16bit) accesses' here to make this a bit more
explicit?
> @@ -205,6 +212,7 @@ static const __maybe_unused char cmd_i2c_read_help[] =
> " -a 0x<addr> i2c device address\n"
> " -b <bus_num> i2c bus number (default = 0)\n"
> " -r 0x<reg> start register\n"
> +" -w use the word as an address\n"
> " -c <count> byte count\n";
ditto
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-11 18:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 15:42 [PATCH 1/2] i2c: Fix barebox crash when 'count' is not set for i2c_read command Alexander Shiyan
2012-05-11 15:42 ` [PATCH 2/2] i2c: Added switch for allowing usage 16bit register addresses Alexander Shiyan
2012-05-11 18:15 ` Sascha Hauer [this message]
2012-05-11 18:17 ` Re[2]: " Alexander Shiyan
2012-05-11 18:35 ` Sascha Hauer
2012-05-11 18:58 ` Alexander Shiyan
2012-05-11 20:02 ` Sascha Hauer
2012-05-11 20:17 ` [PATCH 1/2] i2c: Fix barebox crash when 'count' is not set for i2c_read command Alexander Shiyan
2012-05-11 20:17 ` [PATCH 2/2] i2c: Added switch for allowing usage 16bit register addresses Alexander Shiyan
2012-05-11 18:12 ` [PATCH 1/2] i2c: Fix barebox crash when 'count' is not set for i2c_read command Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511181508.GK27341@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox