From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] PCM038: Move USBH2 initialization to PCM970
Date: Mon, 14 May 2012 10:57:58 +0200 [thread overview]
Message-ID: <201205141057.58795.jbe@pengutronix.de> (raw)
In-Reply-To: <1336984452-32194-1-git-send-email-shc_work@mail.ru>
Alexander Shiyan wrote:
> [...]
> @@ -260,19 +238,6 @@ static int pcm038_devices_init(void)
> PA29_PF_VSYNC,
> PA30_PF_CONTRAST,
> PA31_PF_OE_ACD,
> - /* USB host 2 */
> - PA0_PF_USBH2_CLK,
> - PA1_PF_USBH2_DIR,
> - PA2_PF_USBH2_DATA7,
> - PA3_PF_USBH2_NXT,
> - PA4_PF_USBH2_STP,
> - PD19_AF_USBH2_DATA4,
> - PD20_AF_USBH2_DATA3,
> - PD21_AF_USBH2_DATA6,
> - PD22_AF_USBH2_DATA0,
> - PD23_AF_USBH2_DATA2,
> - PD24_AF_USBH2_DATA1,
> - PD26_AF_USBH2_DATA5,
>
> [...]
>
> +#ifdef CONFIG_USB
> +static void pcm970_usbh2_init(void)
> +{
> + int i;
> + uint32_t temp;
> + unsigned int mode[] = {
> + /* USB Host 2 */
> + PA0_PF_USBH2_CLK,
> + PA1_PF_USBH2_DIR,
> + PA2_PF_USBH2_DATA7,
> + PA3_PF_USBH2_NXT,
> + PA4_PF_USBH2_STP,
> + PD19_AF_USBH2_DATA4,
> + PD20_AF_USBH2_DATA3,
> + PD21_AF_USBH2_DATA6,
> + PD22_AF_USBH2_DATA0,
> + PD23_AF_USBH2_DATA2,
> + PD24_AF_USBH2_DATA1,
> + PD26_AF_USBH2_DATA5,
> + };
>
> [...]
This changes the initialization of the pins form 'always' to 'sometimes". I
feel better if pins are physically connected they also should be initialized.
And if the USB software feature is disable they should get initialized as
well to keep the signals in a sane state to not confuse externally attached
devices (in this case it could be useful to configure them as GPIO instead
with reasonable directions and levels).
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-14 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 8:34 Alexander Shiyan
2012-05-14 8:34 ` [PATCH 2/2] Add compressed barebox_default_env to .gitignore Alexander Shiyan
2012-05-14 8:57 ` Juergen Beisert [this message]
2012-05-14 9:50 ` [PATCH 1/2] PCM038: Move USBH2 initialization to PCM970 Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205141057.58795.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox