mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: barebox <barebox@lists.infradead.org>
Cc: Alexey Galakhov <agalakhov@gmail.com>
Subject: Re: [PATCH 3/9] Minimal S5PV210 + Tiny210 support (2nd stage only)
Date: Mon, 14 May 2012 11:57:29 +0200	[thread overview]
Message-ID: <201205141157.29518.jbe@pengutronix.de> (raw)
In-Reply-To: <4FB0D058.3070206@gmail.com>

Hi Alexey,

please keep the mailing list at least on CC.

Alexey Galakhov wrote:
> > It would be all right if you had introduce the basic support first and it
> > is now part of the repository. And *then* add the native boot support as
> > a really second step and separate patch series.
>
> The iROM support should be separated anyway. The reason is, iROM is only
> a temporary solution until we have a working replacement. This patch is
> designed to be easily reverted separately as soon as we'll able to boot
> without it.
>
> Using iROM to boot is generally a bad idea, but there's no alternative
> right now.

For you there might be no alternative right now. But for Barebox its all right 
if only a basic support for this new CPU is available.

> I think the correct patch series should look like that:
>
> * make some space for everything (not introducing anything new, to be
>   able to use git bisect if things do break)
> * add support of the new architecture to the existing code
> * add support for specific PLL
> * add support for specific DRAM
> * add support for iROM

Skip the iROM entirely in your patch series if you want to remove it later on. 
What sense would it make to include it and then remove it again?

> * finally, add new board.

Yes. This step makes use of all the steps above (but not the iROM).

> The point is, if one reverts these patches one by one from the end, the
> rest will be usable.

There is almost _never_ a reason to revert a complete patch. If an older patch 
has introduced a regression then there will be a new patch that fixes it and 
explains why and how to fix.

> However, there's one bad thing: it's better to add at least one board to
> Kconfig with the new arch.

?

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-05-14  9:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-12 16:23 [Pull request] Minimal S5PV210 support Alexey Galakhov
2012-05-13  9:09 ` Sascha Hauer
2012-05-13 12:39   ` [PATCH 0/9] " Alexey Galakhov
2012-05-13 12:39     ` [PATCH 1/9] Support most Samsung SoCs in S3C serial driver Alexey Galakhov
2012-05-13 12:39     ` [PATCH 2/9] Fine split S3C arch dependencies from generic code Alexey Galakhov
2012-05-14  8:03       ` Juergen Beisert
2012-05-14  8:54         ` Alexey Galakhov
2012-05-14  8:57           ` Sascha Hauer
2012-05-14  8:59             ` Alexey Galakhov
2012-05-14  9:00           ` Juergen Beisert
2012-05-14  9:30             ` Alexey Galakhov
2012-05-14  8:12       ` Sascha Hauer
2012-05-13 12:40     ` [PATCH 3/9] Minimal S5PV210 + Tiny210 support (2nd stage only) Alexey Galakhov
2012-05-14  8:13       ` Juergen Beisert
2012-05-14  8:57         ` Alexey Galakhov
2012-05-14  9:04           ` Juergen Beisert
     [not found]             ` <4FB0D058.3070206@gmail.com>
2012-05-14  9:57               ` Juergen Beisert [this message]
2012-05-14 11:07                 ` Alexey Galakhov
2012-05-14 13:07                   ` Juergen Beisert
2012-05-14 13:38                     ` Alexey Galakhov
2012-05-13 12:40     ` [PATCH 4/9] S5PV210 iROM magic boot code Alexey Galakhov
2012-05-14  7:51       ` Sascha Hauer
2012-05-14  8:55         ` Alexey Galakhov
2012-05-13 12:40     ` [PATCH 5/9] S5P DRAM support Alexey Galakhov
2012-05-13 12:40     ` [PATCH 6/9] S5P lowlevel clock init Alexey Galakhov
2012-05-13 12:40     ` [PATCH 7/9] Revert "S5PV210 iROM magic boot code" Alexey Galakhov
2012-05-13 12:40     ` [PATCH 8/9] S5P iROM boot support - improved Alexey Galakhov
2012-05-13 12:40     ` [PATCH 9/9] S5P boot header and image generator Alexey Galakhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205141157.29518.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=agalakhov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox