* [PATCH] ARM i.MX: Possible bug fixed due misspelling when copy/paste
@ 2012-05-22 18:48 Alexander Shiyan
2012-05-29 9:09 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Shiyan @ 2012-05-22 18:48 UTC (permalink / raw)
To: barebox
We must check pointer to function rather than result.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/mach-imx/speed-imx51.c | 4 ++--
arch/arm/mach-imx/speed-imx53.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-imx/speed-imx51.c b/arch/arm/mach-imx/speed-imx51.c
index 84f4892..5a845a6 100644
--- a/arch/arm/mach-imx/speed-imx51.c
+++ b/arch/arm/mach-imx/speed-imx51.c
@@ -98,9 +98,9 @@ static unsigned long get_rate_select(int select,
{
switch (select) {
case 0:
- return get_rate1() ? get_rate1() : 0;
+ return get_rate1 ? get_rate1() : 0;
case 1:
- return get_rate2() ? get_rate2() : 0;
+ return get_rate2 ? get_rate2() : 0;
case 2:
return get_rate3 ? get_rate3() : 0;
case 3:
diff --git a/arch/arm/mach-imx/speed-imx53.c b/arch/arm/mach-imx/speed-imx53.c
index a2385fa..634341e 100644
--- a/arch/arm/mach-imx/speed-imx53.c
+++ b/arch/arm/mach-imx/speed-imx53.c
@@ -103,9 +103,9 @@ static unsigned long get_rate_select(int select,
{
switch (select) {
case 0:
- return get_rate1() ? get_rate1() : 0;
+ return get_rate1 ? get_rate1() : 0;
case 1:
- return get_rate2() ? get_rate2() : 0;
+ return get_rate2 ? get_rate2() : 0;
case 2:
return get_rate3 ? get_rate3() : 0;
case 3:
--
1.7.3.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM i.MX: Possible bug fixed due misspelling when copy/paste
2012-05-22 18:48 [PATCH] ARM i.MX: Possible bug fixed due misspelling when copy/paste Alexander Shiyan
@ 2012-05-29 9:09 ` Sascha Hauer
2012-05-30 8:53 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2012-05-29 9:09 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On Tue, May 22, 2012 at 10:48:48PM +0400, Alexander Shiyan wrote:
> We must check pointer to function rather than result.
Applied, thanks
Sascha
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/mach-imx/speed-imx51.c | 4 ++--
> arch/arm/mach-imx/speed-imx53.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-imx/speed-imx51.c b/arch/arm/mach-imx/speed-imx51.c
> index 84f4892..5a845a6 100644
> --- a/arch/arm/mach-imx/speed-imx51.c
> +++ b/arch/arm/mach-imx/speed-imx51.c
> @@ -98,9 +98,9 @@ static unsigned long get_rate_select(int select,
> {
> switch (select) {
> case 0:
> - return get_rate1() ? get_rate1() : 0;
> + return get_rate1 ? get_rate1() : 0;
> case 1:
> - return get_rate2() ? get_rate2() : 0;
> + return get_rate2 ? get_rate2() : 0;
> case 2:
> return get_rate3 ? get_rate3() : 0;
> case 3:
> diff --git a/arch/arm/mach-imx/speed-imx53.c b/arch/arm/mach-imx/speed-imx53.c
> index a2385fa..634341e 100644
> --- a/arch/arm/mach-imx/speed-imx53.c
> +++ b/arch/arm/mach-imx/speed-imx53.c
> @@ -103,9 +103,9 @@ static unsigned long get_rate_select(int select,
> {
> switch (select) {
> case 0:
> - return get_rate1() ? get_rate1() : 0;
> + return get_rate1 ? get_rate1() : 0;
> case 1:
> - return get_rate2() ? get_rate2() : 0;
> + return get_rate2 ? get_rate2() : 0;
> case 2:
> return get_rate3 ? get_rate3() : 0;
> case 3:
> --
> 1.7.3.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re[2]: [PATCH] ARM i.MX: Possible bug fixed due misspelling when copy/paste
2012-05-29 9:09 ` Sascha Hauer
@ 2012-05-30 8:53 ` Alexander Shiyan
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Shiyan @ 2012-05-30 8:53 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
Hello.
Tue, 29 May 2012 11:09:45 +0200 от Sascha Hauer <s.hauer@pengutronix.de>:
> On Tue, May 22, 2012 at 10:48:48PM +0400, Alexander Shiyan wrote:
> > We must check pointer to function rather than result.
>
> Applied, thanks
Please apply this to 'next' too. Thanks!
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-30 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-22 18:48 [PATCH] ARM i.MX: Possible bug fixed due misspelling when copy/paste Alexander Shiyan
2012-05-29 9:09 ` Sascha Hauer
2012-05-30 8:53 ` Re[2]: " Alexander Shiyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox