From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v20120528 4/5] toshiba-ac100: add USB host support
Date: Tue, 29 May 2012 12:37:20 +0200 [thread overview]
Message-ID: <20120529103720.GL2202@game.jcrosoft.org> (raw)
In-Reply-To: <20120529083010.GY30400@pengutronix.de>
On 10:30 Tue 29 May , Sascha Hauer wrote:
> On Mon, May 28, 2012 at 12:12:35PM +0400, Antony Pavlov wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > arch/arm/boards/toshiba-ac100/board.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/boards/toshiba-ac100/board.c b/arch/arm/boards/toshiba-ac100/board.c
> > index e3a5eba..3fd720d 100644
> > --- a/arch/arm/boards/toshiba-ac100/board.c
> > +++ b/arch/arm/boards/toshiba-ac100/board.c
> > @@ -24,6 +24,8 @@
> > #include <init.h>
> > #include <asm/armlinux.h>
> > #include <sizes.h>
> > +#include <usb/ehci.h>
> > +#include <mach/iomap.h>
> >
> > static int ac100_mem_init(void)
> > {
> > @@ -32,3 +34,19 @@ static int ac100_mem_init(void)
> > return 0;
> > }
> > mem_initcall(ac100_mem_init);
> > +
> > +#ifdef CONFIG_USB_EHCI
> > +static struct ehci_platform_data ehci_pdata = {
> > + .flags = EHCI_HAS_TT,
> > +};
> > +#endif
> > +
> > +static int ac100_devices_init(void)
> > +{
> > +#ifdef CONFIG_USB_EHCI
> > + add_generic_usb_ehci_device(-1, TEGRA_USB3_BASE, &ehci_pdata);
> > +#endif
>
> Better skip the ifdefs. It won't hurt except for a few bytes of wated
> space.
and the -1 need to be a define
btw I think we need to change the auto allocated dev_id to -2 so -1 one have
the same meanning as in the kernel
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-29 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 8:12 [PATCH v20120528 0/5] ARM: initial Tegra support Antony Pavlov
2012-05-28 8:12 ` [PATCH v20120528 1/5] " Antony Pavlov
2012-05-28 8:12 ` [PATCH v20120528 2/5] ARM: Tegra: add Toshiba AC100 support Antony Pavlov
2012-05-28 8:12 ` [PATCH v20120528 3/5] usb: set MAXINTERFACES = 16 Antony Pavlov
2012-05-28 8:12 ` [PATCH v20120528 4/5] toshiba-ac100: add USB host support Antony Pavlov
2012-05-29 8:30 ` Sascha Hauer
2012-05-29 10:37 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-05-29 10:42 ` Sascha Hauer
2012-05-29 15:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-29 16:09 ` Sascha Hauer
2012-05-29 10:55 ` Antony Pavlov
2012-05-28 8:12 ` [PATCH v20120528 5/5] toshiba_ac100: add defconfig Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529103720.GL2202@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox