From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] MIPS: XBurst: suitable solution for per-board debug_ll
Date: Sat, 2 Jun 2012 04:52:22 +0200 [thread overview]
Message-ID: <20120602025222.GO2202@game.jcrosoft.org> (raw)
In-Reply-To: <1338542601-28151-2-git-send-email-antonynpavlov@gmail.com>
On 13:23 Fri 01 Jun , Antony Pavlov wrote:
> In the commit 40492a0c1305835c996e15eb1cce2406473ae76d
> (MIPS: add common header file for DEBUG_LL via NS16550)
> introduced common DEBUG_LL via NS16550 for MIPS
> (see file arch/mips/include/debug_ll_ns16550.h).
>
> In the commit 1cbe2b2c00de0efca503a983d0d008833f186f33
> (MIPS: XBurst: add Ritmix RZX-50 board support)
> the file debug_ll_ns16550.h used in
> the file arch/mips/mach-xburst/include/mach/debug_ll.h.
>
> Usage looks like this:
>
> ------------------------------------------------
> +#ifdef CONFIG_BOARD_RZX50
> +#include <mach/debug_ll_jz4755.h>
> +#endif
> +
> +#include <debug_ll_ns16550.h>
> ------------------------------------------------
>
> So after adding another board (e.g. A320) we will have something like this:
>
> ------------------------------------------------
> #ifdef CONFIG_BOARD_RZX50
> #include <mach/debug_ll_jz4755.h>
> #endif
>
I'll include it via config.h or at least have a common hearder name and just
have a single config to enable it and then enable it at board config level
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-06-02 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 9:23 [PATCH 1/2] MIPS: make possible board-specific header files Antony Pavlov
2012-06-01 9:23 ` [PATCH 2/2] MIPS: XBurst: suitable solution for per-board debug_ll Antony Pavlov
2012-06-02 2:52 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-06-02 3:51 ` Antony Pavlov
2012-06-05 6:37 ` [PATCH 1/2] MIPS: make possible board-specific header files Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120602025222.GO2202@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox