From: Sascha Hauer <s.hauer@pengutronix.de>
To: Johannes Stezenbach <js@sig21.net>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH RFC] spi: add support for dual and quad IO modes
Date: Wed, 20 Jun 2012 09:24:46 +0200 [thread overview]
Message-ID: <20120620072446.GI28394@pengutronix.de> (raw)
In-Reply-To: <20120618150656.GA10624@sig21.net>
On Mon, Jun 18, 2012 at 05:06:57PM +0200, Johannes Stezenbach wrote:
> Some flashes and SPI masters support dual and quad IO modes
> where data is transferred in parallel using two or four pins.
> For now add this capability for mx25l25635e.
>
> Signed-off-by: Johannes Stezenbach <js@sig21.net>
> ---
>
> I'm planning to submit a similar patch for Linux sometime
> within the next month or so. Maybe you want to wait
> for the review comments there before including it in barebox,
> but I'm posting this anyway in case someone wants to comment.
> At the moment I'm not able to post the SPI master driver
> which implements it. I'm not sure which if any of the SPI
> masters already included in barebox have the dual and
> quad mode capability, but it's important for boot time.
> BTW, I have checked all users of struct spi_transfer
> properly initialize it to zero so adding the
> multi_io field should not cause problems.
As long as we don't have a SPI master driver supporting multi io I think
we should wait for the corresponding Linux code before applying this
one.
> @@ -552,7 +566,7 @@ static const struct spi_device_id m25p_ids[] = {
> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, 0) },
> { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
> { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> - { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
> + { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, DUAL_IO | QUAD_IO) },
> { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>
> /* Spansion -- single (large) sector size only, at least
> @@ -788,6 +802,10 @@ static int m25p_probe(struct device_d *dev)
> } else {
> flash->erase_opcode = OPCODE_SE;
> }
> + if ((info->flags & DUAL_IO) && (spi->master->flags & SPI_MASTER_DUAL_IO))
> + flash->dual_io = 1;
> + if ((info->flags & QUAD_IO) && (spi->master->flags & SPI_MASTER_QUAD_IO))
> + flash->quad_io = 1;
You enable dual/quad io when both the EEPROM and the master are capable
of doing so. Should we ask the PCB designer aswell if the board actually
has 2/4 lines connected (that is, add a flag to platform data)?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-06-20 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 15:06 Johannes Stezenbach
2012-06-20 7:24 ` Sascha Hauer [this message]
2012-06-20 8:34 ` Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620072446.GI28394@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=js@sig21.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox